[cinder-csi-plugin] Use context #2864
Open
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
cncf-cla: yes
stephenfin
force-pushed
the
cinder-context
branch
from
f264505 to
7159398
Compare
mandre
reviewed
Apr 7, 2025
stephenfin
force-pushed
the
cinder-context
branch
from
7159398 to
489855e
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
the
needs-rebase
Looks like an oversight in commit 7bfb2eb. Signed-off-by: Stephen Finucane <[email protected]>
This confused me. It might confuse others. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
cinder-context
branch
from
489855e to
ad7fffa
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
needs-rebase
kayrus
reviewed
Oct 2, 2025
| return accessibleTopology | ||
| } | ||
|
|
||
| func getCreateVolumeResponse(vol *volumes.Volume, volCtx map[string]string, accessibleTopology []*csi.Topology) *csi.CreateVolumeResponse { |
There was a problem hiding this comment.
we need to cover the cases, when the volCtx argument is nil, e.g.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use the generated VolumeContext.
Which issue this PR fixes(if applicable):
fixes #2863
Special notes for reviewers:
Release note: