Skip to content

Conversation

@okozachenko1203
Copy link
Contributor

@okozachenko1203 okozachenko1203 commented May 13, 2025

What this PR does / why we need it:
This PR supports additional volumes in manila csi chart. Typical use case is to mount ca cert of openstack api.

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

[manila-csi-plugin] add support for additional volumes in helm chart. 
Typical use case is to mount ca cert of openstack api.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2025
@k8s-ci-robot k8s-ci-robot requested review from dulek and stephenfin May 13, 2025 04:01
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @okozachenko1203. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2025
@kayrus
Copy link
Contributor

kayrus commented May 13, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2025
@kayrus
Copy link
Contributor

kayrus commented May 13, 2025

@okozachenko1203 thanks for the PR, please fill in the release notes.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 14, 2025
@okozachenko1203
Copy link
Contributor Author

@okozachenko1203 thanks for the PR, please fill in the release notes.

done

Copy link
Contributor

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit which will probably prevent it from merging

@okozachenko1203 okozachenko1203 force-pushed the support-additional-volumes-in-manila-csi-chart branch from 785a65b to 38b95fe Compare May 15, 2025 15:39
@okozachenko1203 okozachenko1203 requested a review from mnaser May 15, 2025 15:40
@mnaser
Copy link
Contributor

mnaser commented May 15, 2025

/lgtm

but it doesnt count for me here :)

@k8s-ci-robot
Copy link
Contributor

@mnaser: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

but it doesnt count for me here :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser
Copy link
Contributor

mnaser commented May 16, 2025

@okozachenko1203 sadly we're conflicting again, can you please push up the fix again?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2025
@okozachenko1203 okozachenko1203 force-pushed the support-additional-volumes-in-manila-csi-chart branch from 38b95fe to 557b4ff Compare May 19, 2025 06:04
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2025
@kayrus
Copy link
Contributor

kayrus commented May 19, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 71f829a into kubernetes:master May 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants