Skip to content

Conversation

@garloff
Copy link
Contributor

@garloff garloff commented May 22, 2025

[cinder-csi-plugin] helm charts: Use /etc/config/ for cloud.conf
This path is used by default in the deployment manifests for cinder-csi as well as in manifests and helm charts for occm.
It does not matter much until you reference another file via ca-file=/etc/config/cacert
in your cloud.conf and assume that to work.

So better align the volumeMount location everywhere. As there is a canonical location where most artifacts already agree on, let's use it in cinder-csi helm charts as well.

What this PR does / why we need it:
Make the cinder-csi-plugin helm charts work if we pass a secret with cloud.conf and a cacert referenced from there assuming the /etc/config path.
This works with occm (deployment manifests and helm charts) and cinder-csi deployment manifests, but not currently with the cinder-csi helm charts due to using /etc/kubernetes there.
This PR aligns cinder-csi helm charts to also use the canonical path.

Reference:
SovereignCloudStack/cluster-stacks#188 (comment)

Release note:

* [cinder-csi-plugin] Use `/etc/config` in helm charts rather than `/etc/kubernetes` for `cloud.conf`, so any referenced file (e.g. `cacert`) is found.

(Feel free to not add this if determined not to be significant enough.)

This path is used by default in the deployment manifests for cinder-csi
as well as in manifests and helm charts for occm.
It does not matter much until you reference another file via
ca-file=/etc/config/cacert
in your cloud.conf and assume that to work.

So better align the volumeMount location everywhere.
As there is a canonical location where most artifacts already agree on,
let's use it in cinder-csi helm charts as well.

Signed-off-by: Kurt Garloff <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @garloff. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2025
garloff added a commit to SovereignCloudStack/cluster-stacks that referenced this pull request May 22, 2025
@kayrus
Copy link
Contributor

kayrus commented May 22, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit a7c0e20 into kubernetes:master May 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants