-
Notifications
You must be signed in to change notification settings - Fork 649
[occm] Fix incorrect SA name in auth-delegate clusterRoleBiding in OCCM helm chart #2907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @HaoruiPeng! |
|
Hi @HaoruiPeng. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @HaoruiPeng , could you please fix lint warnings? |
c83932d to
cd02141
Compare
|
Hi @kayrus, lint warning fixed :) |
f274b84 to
4e8f4ac
Compare
4e8f4ac to
33d6764
Compare
33d6764 to
c9fc4bf
Compare
c9fc4bf to
99dd650
Compare
What this PR does / why we need it:
OCCM helm chart binds clusterrole 'system:auth-delegator' to service account
openstack-cloud-controller-managerfor service monitor, the value is read fromoccm.name.However the correct SA name created by the chart is 'cloud-controller-manager', value read from
.Values.serviceAccountName.Which issue this PR fixes(if applicable):
The wrong SA name caused that the service monitor fails the authentication to create tokenreviews:
Error message:
Special notes for reviewers:
Release note: