Skip to content

Conversation

stephenfin
Copy link
Member

What this PR does / why we need it:

This option is only useful if you are manually configuring volume AZs using the topology Storage Class parameter. Update docs to reflect this and suggest (likely better) alternatives for working around AZ mismatches.

Which issue this PR fixes(if applicable):
fixes #2185

Special notes for reviewers:

#2865 makes the topology code easier (IMO) to grok, if anyone doubts my testing notes from #2185 (comment).

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2025
@k8s-ci-robot k8s-ci-robot requested review from dulek and kayrus September 1, 2025 13:58
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2025
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now much clearer what ignore-volume-az does. Also nice to have instructions for what to do when pods won't schedule in multi-AZ environments.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@kayrus
Copy link
Contributor

kayrus commented Sep 10, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 37d37d5 into kubernetes:master Sep 10, 2025
4 checks passed
@mandre mandre deleted the fix-ignore-volume-az-docs branch September 10, 2025 09:53
@rptaylor
Copy link
Contributor

rptaylor commented Sep 10, 2025

@stephenfin thanks for this clarification!
Do you know how this relates to the --feature-gates=Topology=false setting that is applied by the Helm chart?
https://github.com/kubernetes/cloud-provider-openstack/blob/master/charts/cinder-csi-plugin/templates/controllerplugin-deployment.yaml#L72

Mentioned here: https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/cinder-csi-plugin/features.md#topology

If you have --feature-gates=Topology=false is it still necessary to also set --with-topology=false for the node and controller plugins (.Values.csi.plugin.controllerPlugin.extraArgs, .Values.csi.plugin.nodePlugin.extraArgs) ?

@stephenfin
Copy link
Member Author

@stephenfin thanks for this clarification! Do you know how this relates to the --feature-gates=Topology=false setting that is applied by the Helm chart? master/charts/cinder-csi-plugin/templates/controllerplugin-deployment.yaml#L72

Mentioned here: master/docs/cinder-csi-plugin/features.md#topology

If you have --feature-gates=Topology=false is it still necessary to also set --with-topology=false for the node and controller plugins (.Values.csi.plugin.controllerPlugin.extraArgs, .Values.csi.plugin.nodePlugin.extraArgs) ?

No, it's not. Setting that to false disables it at the provisioning stage. However, note that feature flags are not kept around forever and this will eventually be removed from the provisioner. This was the rationale for adding the --with-topology flag. When it is, these charts will break. We likely need to update them sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] ignore-volume-az appears to be either useless or incorrectly documented

5 participants