-
Notifications
You must be signed in to change notification settings - Fork 647
[cinder-csi-plugin] Update ignore-volume-az docs #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cinder-csi-plugin] Update ignore-volume-az docs #2985
Conversation
Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now much clearer what ignore-volume-az
does. Also nice to have instructions for what to do when pods won't schedule in multi-AZ environments.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kayrus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@stephenfin thanks for this clarification! Mentioned here: https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/cinder-csi-plugin/features.md#topology If you have |
No, it's not. Setting that to |
What this PR does / why we need it:
This option is only useful if you are manually configuring volume AZs using the
topology
Storage Class parameter. Update docs to reflect this and suggest (likely better) alternatives for working around AZ mismatches.Which issue this PR fixes(if applicable):
fixes #2185
Special notes for reviewers:
#2865 makes the topology code easier (IMO) to grok, if anyone doubts my testing notes from #2185 (comment).
Release note: