Helm: allow vsphere.conf to be sourced from hostPath #1677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an optional Helm configuration to allow vsphere.conf to be sourced from a hostPath volume.
This is useful for bootstrap and constrained environments where the configuration file already exists on the node and creating a ConfigMap/Secret is not desirable. The default behavior using a ConfigMap remains unchanged.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1460Special notes for your reviewer:
The change is fully backward compatible (config.source=configMap remains the default).
When config.source=hostPath, the ConfigMap is not created and the DaemonSet mounts the file directly from the node filesystem.
Helm validation is included to prevent misconfiguration.
Release note: