Merge pull request #508 from floreks/integration-text-fix

Fixed test flakiness on application deploy in IE

Author: Sebastian Florek

src/app/frontend/deploy/deploy.html

@@ -45,7 +45,8 @@ <h3 class="md-headline kd-deploy-form-title">Deploy a Containerized App</h3>
         </deploy-from-file>
       </div>
 
-      <md-button class="md-raised md-primary" type="submit" ng-disabled="ctrl.isDeployDisabled()">
+      <md-button id="kd-deploy-btn" class="md-raised md-primary" type="submit"
+                 ng-disabled="ctrl.isDeployDisabled()">
         Deploy
       </md-button>
       <md-button class="md-raised" ng-click="ctrl.cancel()">Cancel</md-button>

src/test/integration/deploy/deploy_po.js

@@ -14,7 +14,7 @@
 
 export default class DeployPageObject {
   constructor() {
-    this.deployButtonQuery = by.buttonText('Deploy');
+    this.deployButtonQuery = by.id('kd-deploy-btn');
     this.deployButton = element(this.deployButtonQuery);
 
     this.appNameFieldQuery = by.model('ctrl.name');

src/test/integration/stories/deploy_and_delete_replication_controller.js

@@ -64,10 +64,10 @@ describe('Deploy and delete replication controller user story test', () => {
   });
 
   it('should deploy replication controller', () => {
-    deployPage.deployButton.click();
-
-    expect(browser.getCurrentUrl()).toContain('replicationcontrollers');
-    expect(element(by.xpath(applicationCardXPath))).not.toBeNull();
+    deployPage.deployButton.click().then(() => {
+      expect(browser.getCurrentUrl()).toContain('replicationcontrollers');
+      expect(element(by.xpath(applicationCardXPath))).not.toBeNull();
+    });
   });
 
   it('should open delete replication controller dialog', () => {

src/test/integration/stories/deploy_not_existing_img_test.js

@@ -80,10 +80,10 @@ describe('Deploy not existing image story', () => {
     deployPage.containerImageField.sendKeys(containerImage);
 
     // when
-    deployPage.deployButton.click();
-
-    // then
-    expect(browser.getCurrentUrl()).toContain('replicationcontrollers');
+    deployPage.deployButton.click().then(() => {
+      // then
+      expect(browser.getCurrentUrl()).toContain('replicationcontrollers');
+    });
   });
 
   it('should wait for card to be in error state', () => {