Skip to content

Commit 032cb02

Browse files
committed
Address comments
1 parent 56298f4 commit 032cb02

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

keps/sig-storage/2268-non-graceful-shutdown/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -409,13 +409,13 @@ Pick one more of these and delete the rest.
409409
- [X] Metrics
410410
- Metric name:
411411
- New metrics are added in Pod GC Controller:
412-
- `force_delete_pods_total`, the number of pods that are being forcefully deleted since the Pod GC Controller started.
413-
- `force_delete_pod_errors_total`, the number of errors encountered when forcefully deleting the pods since the Pod GC Controller started.
412+
- `force_delete_pods_total{reason="out-of-service|terminated|orphaned|unscheduled"}`, the number of pods that are being forcefully deleted since the Pod GC Controller started.
413+
- `force_delete_pod_errors_total{reason="out-of-service|terminated|orphaned|unscheduled"}`, the number of errors encountered when forcefully deleting the pods since the Pod GC Controller started.
414414
- For Attach Detach Controller, there's already a metric:
415415
- `attachdetach_controller_forced_detaches`, the number of times the Attach Detach Controller performed a forced detach.
416416
- There is also a `kube_node_spec_taint` in [kube-state-metrics](https://github.com/kubernetes/kube-state-metrics/blob/main/docs/node-metrics.md) that is a metric for the taint of a Kubernetes cluster node.
417417
- [Optional] Aggregation method:
418-
- Components exposing the metric:
418+
- Components exposing the metric: kube-controller-manager
419419
- [X] Other (treat as last resort)
420420
- Details:
421421
- Check whether the workload moved to a different running node

keps/sig-storage/2268-non-graceful-shutdown/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,5 @@ disable-supported: true
4343

4444
# The following PRR answers are required at beta release
4545
metrics:
46-
- force_delete_pods_total
47-
- force_delete_pod_errors_total
46+
- force_delete_pods_total{reason="out-of-service|terminated|orphaned|unscheduled"}
47+
- force_delete_pod_errors_total{reason="out-of-service|terminated|orphaned|unscheduled"}

0 commit comments

Comments
 (0)