Skip to content

Commit 0438bc7

Browse files
committed
Address review comments
Signed-off-by: Rita Zhang <[email protected]>
1 parent a1b9721 commit 0438bc7

File tree

1 file changed

+9
-3
lines changed
  • keps/sig-auth/3221-structured-authorization-configuration

1 file changed

+9
-3
lines changed

keps/sig-auth/3221-structured-authorization-configuration/README.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,6 @@ Labels {along with possible values}:
472472

473473
- `name`
474474
- `code` {"incomplete_request", "bad_response"}
475-
- `decision` {NoOpinion}
476475

477476
5. `apiserver_authorization_configuration_reload_last_timestamp_seconds`
478477

@@ -595,6 +594,13 @@ The behaviour is the same as when the feature is enabled for the first time.
595594
We will have extensive unit tests during feature implementation. There would be tests
596595
for the Authorizer chain in both the old and new configuration scenarios.
597596

597+
We will add integration tests to validate the enablement/disablement flow.
598+
- When the feature is disabled, only the existing command line flag `--authorization-webhook-*`
599+
based mode is allowed.
600+
- When the feature is enable, setting both `--authorization-config-file` and
601+
configuring an authorization webhook using the `--authorization-webhook-*`
602+
command line flags should return an error.
603+
598604
### Rollout, Upgrade and Rollback Planning
599605

600606
> Note: This section is required when targeting Beta to a release.
@@ -690,7 +696,7 @@ None
690696

691697
### Scalability
692698

693-
> Note: This section is good-to-have to Alpha.
699+
> Note: This section is good-to-have for Alpha.
694700

695701
###### Will enabling / using this feature result in any new API calls?
696702

@@ -731,7 +737,7 @@ This through this both in small and large cases, again with respect to the
731737
[supported limits]: https://git.k8s.io/community//sig-scalability/configs-and-limits/thresholds.md
732738
-->
733739

734-
There would a very small addition to the memory used by the API Server and
740+
No. There would be very minimal addition to the memory used by the API Server and
735741
number of log entries written to the disk. During the Alpha implementation,
736742
the small impact will be measured and rationalized to keep the addition
737743
minimal. The addition would be well within the scalability limits and

0 commit comments

Comments
 (0)