Skip to content

Commit 3f72dce

Browse files
committed
Add more details about the pull policy
Signed-off-by: Sascha Grunert <[email protected]>
1 parent 1dc558b commit 3f72dce

File tree

1 file changed

+13
-2
lines changed
  • keps/sig-node/4639-oci-volume-source

1 file changed

+13
-2
lines changed

keps/sig-node/4639-oci-volume-source/README.md

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ tags, and then generate with `hack/update-toc.sh`.
9494
- [Design Details](#design-details)
9595
- [Kubelet and Container Runtime Interface (CRI) support for OCI artifacts](#kubelet-and-container-runtime-interface-cri-support-for-oci-artifacts)
9696
- [kubelet](#kubelet)
97+
- [Pull Policy](#pull-policy)
98+
- [Registry authentication](#registry-authentication)
9799
- [CRI](#cri)
98100
- [Container Runtimes](#container-runtimes)
99101
- [SELinux](#selinux)
@@ -341,8 +343,17 @@ be reused, for example:
341343
- The retrieval of available secrets for a pod:
342344
https://github.com/kubernetes/kubernetes/blob/39c6bc3/pkg/kubelet/kubelet_pods.go#L988
343345
344-
Specifying a `pullPolicy` be supported in the same way as for the existing
345-
`imagePullPolicy` API.
346+
##### Pull Policy
347+
348+
While the `imagePullPolicy` is working on container level, the introduced
349+
`pullPolicy` is a pod level construct. This means that we can support the same
350+
values `IfNotPresent`, `Always` and `Never`, but will only pull once per pod.
351+
352+
This means we need to pull in [`SyncPod`](https://github.com/kubernetes/kubernetes/blob/b498eb9/pkg/kubelet/kuberuntime/kuberuntime_manager.go#L1049)
353+
for OCI objects on a pod level and not during [`EnsureImageExists`](https://github.com/kubernetes/kubernetes/blob/b498eb9/pkg/kubelet/images/image_manager.go#L102)
354+
before the container gets started.
355+
356+
##### Registry authentication
346357

347358
For registry authentication purposes the same logic will be used as for the
348359
container image.

0 commit comments

Comments
 (0)