Skip to content

Commit 4e06845

Browse files
committed
Add Upgrade/Downgrade strategy
1 parent fc95a65 commit 4e06845

File tree

1 file changed

+4
-3
lines changed
  • keps/sig-storage/1790-recover-resize-failure

1 file changed

+4
-3
lines changed

keps/sig-storage/1790-recover-resize-failure/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
- [Graduation Criteria](#graduation-criteria)
2929
- [Alpha](#alpha)
3030
- [Beta](#beta)
31-
- [GA](#ga)
31+
- [GA](#ga)
3232
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
3333
- [Version Skew Strategy](#version-skew-strategy)
3434
- [Monitoring](#monitoring)
@@ -343,14 +343,15 @@ There are already e2e tests running that verify correctness of this feature - ht
343343
- There are already e2e tests running that verify correctness of this feature -
344344
https://testgrid.k8s.io/presubmits-kubernetes-nonblocking#pull-kubernetes-e2e-gce-cos-alpha-features
345345

346-
### GA
346+
#### GA
347347

348348
- The feature has been extensively tested in CI and deployed with drivers in real world. For example - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/latest/azuredisk-csi-driver/templates/csi-azuredisk-controller.yaml#L166
349349
- The test grid already has tests for the feature.
350350

351351
### Upgrade / Downgrade Strategy
352352

353-
Not Applicable
353+
- For the case of older kubelet running with newer resizer, the kubelet must handle the newer fields introduced by this feature even if feature-gate is not enabled. Having said that, if kubelet is older and has no notion of this feature at all and `api-server` and `external-resizer` is newer, it is possible that kubelet will not properly update `allocatedResourceStatus` after expansion is finished on the node. This is a known limitation and if user wants to keep running older version of kubelet (older than v1.31 as of this writing and hence unsupported), then they MUST not update external-resizer.
354+
- In general `external-resizer` should only be upgraded(and `RecoverVolumeExpansionFailure` enabled), after `kubelet`, `api-server` and `kube-controller-manager` already has this feature enabled.
354355

355356
### Version Skew Strategy
356357

0 commit comments

Comments
 (0)