Skip to content

Commit 5031d61

Browse files
authored
Merge pull request #5406 from rzlink/kep5100
KEP-5100: update KEP to `stable`
2 parents 9f63a07 + 051d5e6 commit 5031d61

File tree

3 files changed

+21
-8
lines changed

3 files changed

+21
-8
lines changed

keps/prod-readiness/sig-windows/5100.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,5 @@
44
kep-number: 5100
55
beta:
66
approver: "@soltysh"
7+
stable:
8+
approver: "@soltysh"

keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,16 +137,16 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
137137
- [X] (R) KEP approvers have approved the KEP status as `implementable`
138138
- [X] (R) Design details are appropriately documented
139139
- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
140-
- [ ] e2e Tests for all Beta API Operations (endpoints)
141-
- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
142-
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
140+
- [X] e2e Tests for all Beta API Operations (endpoints)
141+
- [X] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
142+
- [X] (R) Minimum Two Week Window for GA e2e tests to prove flake free
143143
- [X] (R) Graduation criteria is in place
144-
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
144+
- [X] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
145145
- [X] (R) Production readiness review completed
146146
- [X] (R) Production readiness review approved
147147
- [X] "Implementation History" section is up-to-date for milestone
148-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
149-
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
148+
- [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
149+
- [X] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
150150

151151
<!--
152152
**Note:** This checklist is iterative and should be reviewed and updated every time this enhancement is being considered for a milestone.
@@ -459,6 +459,9 @@ N/A - This feature is already implemented.
459459

460460
- 2 or more CNI solutions support overlay networking mode for Windows nodes.
461461

462+
1. [Calico networking](https://github.com/projectcalico/calico/blob/cf9455706a1fc6e9d5b11e4556f3d087007124e7/node/windows-packaging/CalicoWindows/kubernetes/kube-proxy-service.ps1#L65-L79) on Windows enables WinOverlay feature if the underlying HNS network is of type overlay.
463+
2. [Flannel](https://github.com/microsoft/SDN/blob/master/Kubernetes/flannel/start-kubeproxy.ps1#L19-L28) networking does the same.
464+
462465
<!--
463466
464467
**Note:** Generally we also wait at least two releases between beta and
@@ -616,6 +619,11 @@ For DSR, kube-proxy should resync HNS rules and start using DSR again.
616619

617620
###### Are there any tests for feature enablement/disablement?
618621

622+
We have periodic test passes running in prow that use both of these configurations
623+
624+
- [capz-windows-master-containerd2](https://testgrid.k8s.io/sig-windows-signal#capz-windows-master-containerd2) all of the Windows CAPZ tests use calico by default.
625+
- [ltsc2025-containerd-flannel-sdnoverlay-master](https://testgrid.k8s.io/sig-windows-networking#ltsc2025-containerd-flannel-sdnoverlay-master) for flannel with overlay networking mode.
626+
619627
<!--
620628
The e2e framework does not currently support enabling or disabling feature
621629
gates. However, unit tests in each component dealing with managing data, created
@@ -967,6 +975,8 @@ We have not observed any additional failure modes with DSR or overlay networking
967975

968976
###### What steps should be taken if SLOs are not being met to determine the problem?
969977

978+
See [Troubleshooting](#troubleshooting)
979+
970980
## Implementation History
971981

972982
<!--

keps/sig-windows/5100-windows-dsr-and-overlay-support/kep.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,18 @@ approvers:
1818
# The target maturity stage in the current dev cycle for this KEP.
1919
# If the purpose of this KEP is to deprecate a user-visible feature
2020
# and a Deprecated feature gates are added, they should be deprecated|disabled|removed.
21-
stage: beta
21+
stage: stable
2222

2323
# The most recent milestone for which work toward delivery of this KEP has been
2424
# done. This can be the current (upcoming) milestone, if it is being actively
2525
# worked on.
26-
latest-milestone: "v1.33"
26+
latest-milestone: "v1.34"
2727

2828
# The milestone at which this feature was, or is targeted to be, at each stage.
2929
milestone:
3030
alpha: "v1.14"
3131
beta: "v1.33"
32+
stable: "v1.34"
3233

3334
# The following PRR answers are required at alpha release
3435
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)