Skip to content

Commit 94314b9

Browse files
committed
Add reason for attachdetach_controller_forced_detaches metric
1 parent 032cb02 commit 94314b9

File tree

1 file changed

+2
-2
lines changed
  • keps/sig-storage/2268-non-graceful-shutdown

1 file changed

+2
-2
lines changed

keps/sig-storage/2268-non-graceful-shutdown/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,8 +411,8 @@ Pick one more of these and delete the rest.
411411
- New metrics are added in Pod GC Controller:
412412
- `force_delete_pods_total{reason="out-of-service|terminated|orphaned|unscheduled"}`, the number of pods that are being forcefully deleted since the Pod GC Controller started.
413413
- `force_delete_pod_errors_total{reason="out-of-service|terminated|orphaned|unscheduled"}`, the number of errors encountered when forcefully deleting the pods since the Pod GC Controller started.
414-
- For Attach Detach Controller, there's already a metric:
415-
- `attachdetach_controller_forced_detaches`, the number of times the Attach Detach Controller performed a forced detach.
414+
- For Attach Detach Controller, the following metric will be recorded if a force detach is performed because the node has the `out-of-service` taint or a timeout happens:
415+
- `attachdetach_controller_forced_detaches{reason="out-of-service|timeout"}`, the number of times the Attach Detach Controller performed a forced detach.
416416
- There is also a `kube_node_spec_taint` in [kube-state-metrics](https://github.com/kubernetes/kube-state-metrics/blob/main/docs/node-metrics.md) that is a metric for the taint of a Kubernetes cluster node.
417417
- [Optional] Aggregation method:
418418
- Components exposing the metric: kube-controller-manager

0 commit comments

Comments
 (0)