Skip to content

Commit c9b7424

Browse files
committed
Be explicit about implementation not creating additional TLS connections
1 parent 7359ae0 commit c9b7424

File tree

1 file changed

+1
-3
lines changed
  • keps/sig-auth/4872-harden-kubelet-cert-validation

1 file changed

+1
-3
lines changed

keps/sig-auth/4872-harden-kubelet-cert-validation/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ Alternatively the can check the `kubernetes_feature_enabled` metric.
304304
The average `apiserver_request_duration_seconds` for logs/exec/port-forward requests is within reasonable limits.
305305
A raising value after enabling this feature could signal overhead introduced by the extra validation.
306306

307-
> TODO: I expect the overhead to be negligible and probably to fall in within the standard deviation of the current average. Specially for long running requests like port-forward and exec. Is this even valuable to have here?
307+
In addition, the number of TLS connections made from API server to nodes should not increase.
308308

309309
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
310310

@@ -352,8 +352,6 @@ No. This only affects streaming APIs and these are not covered by SLIs/SLOs.
352352

353353
No.
354354

355-
Note: depending on the implementation (caching the client-go transport or not) there might be a slight increase in memory (due to one transport per node being cached) or in CPU usage (due to building the transport on the fly for every request). This should be negligible.
356-
357355
###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
358356

359357
No.

0 commit comments

Comments
 (0)