Skip to content

Commit cde58c3

Browse files
committed
cleanup
1 parent f0d90bd commit cde58c3

File tree

1 file changed

+6
-6
lines changed
  • keps/sig-api-machinery/4020-unknown-version-interoperability-proxy

1 file changed

+6
-6
lines changed

keps/sig-api-machinery/4020-unknown-version-interoperability-proxy/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ API server change:
210210
with the resources it can serve and receiving a request for a resource
211211
that is not yet available on that apiserver).
212212

213-
* Discovery merging.
213+
* Discovery merging:
214214

215215
- During upgrade or downgrade, it may be the case that no apiserver has a
216216
complete list of available resources. To fix the problems mentioned, it's
@@ -324,7 +324,7 @@ How the masterlease reconciler will be used is as follows:
324324

325325
1. We will use the already existing IP in Endpoints.Subsets.Addresses of the masterlease by default
326326

327-
2. For users with network configurations that would not allow Endpoints.Subsets.Addresses to be reachable from a kube-apiserver, we will introduce a new --advertise-peer-ip flag to kube-apiserver. We will store its value as an annotation on the masterlease and use this to route the request to the right destination server
327+
2. For users with network configurations that would not allow Endpoints.Subsets.Addresses to be reachable from a kube-apiserver, we will introduce a new --bind-peer-ip flag to kube-apiserver. We will store its value as an annotation on the masterlease and use this to route the request to the right destination server
328328

329329
3. We will also expose the IP and port information of the kube-apiservers as annotations in APIserver identity lease object for visibility/debugging purposes
330330

@@ -356,7 +356,7 @@ when drafting this test plan.
356356
[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
357357
-->
358358

359-
[X] I/we understand the owners of the involved components may require updates to
359+
[x] I/we understand the owners of the involved components may require updates to
360360
existing tests to make this code solid enough prior to committing the changes necessary
361361
to implement this enhancement.
362362

@@ -685,7 +685,7 @@ logs or events for this purpose.
685685
-->
686686

687687
The following metrics could be used to see if the feature is in use:
688-
- kubernetes_uvip_total
688+
- kubernetes_uvip_proxied_request_total
689689

690690
###### How can someone using this feature know that it is working for their instance?
691691

@@ -698,7 +698,7 @@ and operation of this feature.
698698
Recall that end users cannot usually observe component logs or access metrics.
699699
-->
700700

701-
- Metrics like kubernetes_uvip_total can be used to check how many requests were proxied to remote apiserver
701+
- Metrics like kubernetes_uvip_proxied_request_total can be used to check how many requests were proxied to remote apiserver
702702

703703
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
704704

@@ -726,7 +726,7 @@ Pick one more of these and delete the rest.
726726
-->
727727

728728
- [X] Metrics
729-
- Metric name: `kubernetes_uvip_total`
729+
- Metric name: `kubernetes_uvip_proxied_request_total`
730730
- Components exposing the metric: kube-apiserver
731731

732732
###### Are there any missing metrics that would be useful to have to improve observability of this feature?

0 commit comments

Comments
 (0)