Skip to content

Conversation

dgrisonnet
Copy link
Member

@dgrisonnet dgrisonnet commented Feb 1, 2023

  • One-line PR description:

This PR update the state of KEP-1748 to stable and set the milestone to 1.27.

We won't be able to update the status of the KEP to implemented until metrics are updated to Stable, but they first need to be BETA.

  • Other comments:

The graduation criteria from BETA to GA is:

Stability over two releases demonstrating cardinality is reasonable and the metrics remain valuable

The metrics have been in Kubernetes since 1.20 so although there are not exposed on the main kube-scheduler endpoint, they've been around for 7 releases already. During that period of time no cardinality explosion has been reported and the metrics are starting to be more widely used:

Unit tests for the test plan have been added in kubernetes/kubernetes#94866.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 1, 2023
@dashpole
Copy link
Contributor

dashpole commented Feb 1, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2023
@logicalhan
Copy link
Member

/assign

Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should promote the scheduler metrics to BETA stability level as a part of graduation of this KEP to stable status, since we're presuming a certain API stability once this feature is stable.

@logicalhan
Copy link
Member

/cc @johnbelamaric

@johnbelamaric
Copy link
Member

Can you answer the new question as well, please? The question is written from the point of view of a node, but I suppose the same question would apply to the control plane node on which the scheduler runs.

https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template#can-enabling--using-this-feature-result-in-resource-exhaustion-of-some-node-resources-pids-sockets-inodes-etc

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2023
@dgrisonnet dgrisonnet force-pushed the kep-1748 branch 2 times, most recently from d7bfccd to 13dfc92 Compare February 8, 2023 10:24
@dgrisonnet
Copy link
Member Author

I answered the new PRR questions and updated kubernetes/kubernetes#115454 to graduate the metrics to BETA.

@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@dgrisonnet
Copy link
Member Author

@dashpole could you please have another look?

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dgrisonnet, johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 59adedd into kubernetes:master Feb 9, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants