-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-1748: update to stable #3810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/lgtm |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should promote the scheduler metrics to BETA
stability level as a part of graduation of this KEP to stable status, since we're presuming a certain API stability once this feature is stable.
/cc @johnbelamaric |
Can you answer the new question as well, please? The question is written from the point of view of a node, but I suppose the same question would apply to the control plane node on which the scheduler runs. |
Signed-off-by: Damien Grisonnet <[email protected]>
d7bfccd
to
13dfc92
Compare
I answered the new PRR questions and updated kubernetes/kubernetes#115454 to graduate the metrics to BETA. |
/approve |
@dashpole could you please have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, dgrisonnet, johnbelamaric The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR update the state of KEP-1748 to stable and set the milestone to 1.27.
We won't be able to update the status of the KEP to
implemented
until metrics are updated to Stable, but they first need to be BETA.The graduation criteria from BETA to GA is:
The metrics have been in Kubernetes since 1.20 so although there are not exposed on the main kube-scheduler endpoint, they've been around for 7 releases already. During that period of time no cardinality explosion has been reported and the metrics are starting to be more widely used:
Unit tests for the test plan have been added in kubernetes/kubernetes#94866.