Skip to content

Conversation

benluddy
Copy link
Contributor

  • One-line PR description: Adds streaming list encoding as a CBOR beta requirement.
  • Other comments: https://kep.k8s.io/5116 excludes CBOR, but the problem and requirement are effectively the same. We can solve this either with a special case (as has been done for JSON) or by the introduction of generalized streamed encoding to the upstream library.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jul 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benluddy
Once this PR has been reviewed and has the lgtm label, please assign fedebongio for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from fedebongio and sttts July 25, 2025 17:06
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2025
@benluddy
Copy link
Contributor Author

/cc @deads2k @jpbetz

@k8s-ci-robot k8s-ci-robot requested review from deads2k and jpbetz July 25, 2025 17:06
@@ -1084,6 +1084,8 @@ in back-to-back releases.
custom CBOR behaviors.
- All Kubernetes components have opted out of automatic transcoding to JSON for FieldsV1 and
RawExtension.
- List object encoding supports "true" streaming (i.e. buffer size is not proportional to output
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- List object encoding supports "true" streaming (i.e. buffer size is not proportional to output
- Collection (list response) encoding supports "true" streaming (i.e. buffer size is not proportional to output

The response to a list is, AIUI, a collection. And yes, collections have API kinds like PodList. We didn't line up our jargon before the v1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants