KEP-4192: update the KEP to describe the currently implemented behavior #5596
+73
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stanislav Láznička <[email protected]>
…diffs Signed-off-by: Stanislav Láznička <[email protected]>
Signed-off-by: Stanislav Láznička <[email protected]>
Signed-off-by: Stanislav Láznička <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stlaz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
kind/kep
michaelasp
reviewed
Oct 1, 2025
michaelasp
reviewed
Oct 1, 2025
|
|
||
| ### Version Skew Strategy | ||
| The feature will be enabled by the feature gate `StorageVersionMigrator` on both the _api-server_ and the _kube-controller-manager_. This gate must be set for both components during installation. Otherwise, since the kube-controller-manager is allowed to be one version lower than the api-server, it won't be able to process any StorageVersionMigration resources created by the API server. | ||
| The feature will be enabled by the feature gate `StorageVersionMigrator` on the _kube-controller-manager_. |
There was a problem hiding this comment.
There is one other feature gate that I am not fully certain what it does but seems related, InformerResourceVersion. It seems like all it does is return the last synced rv of an informer but it doesn't seem documented anywhere.
Signed-off-by: Stanislav Láznička <[email protected]>
Signed-off-by: Stanislav Láznička <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @michaelasp