Skip to content

KEP-5073: update declarative validation KEP with updated immutability design #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-5073: update declarative validation KEP with updated immutability design #5614

wants to merge 1 commit into from
+267 −166

Conversation

aaron-prindle
Copy link
Contributor

One-line PR description: This addresses how we intend to handle immutability related validations with Declarative Validation.

Issue link: #5073

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from deads2k October 6, 2025 01:38
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sttts October 6, 2025 01:38
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2025
@aaron-prindle aaron-prindle force-pushed the kep-5073-immutable-update branch from 2a215cd to d1367ca Compare October 6, 2025 01:39
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2025
@aaron-prindle aaron-prindle force-pushed the kep-5073-immutable-update branch 4 times, most recently from ceadf66 to 4730a27 Compare October 6, 2025 02:52
@aaron-prindle aaron-prindle force-pushed the kep-5073-immutable-update branch from 4730a27 to ff4124d Compare October 6, 2025 02:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 6, 2025
@aaron-prindle
Copy link
Contributor Author

/cc @yongruilin
/assign @deads2k

jpbetz
jpbetz approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
I'm OK with this approach. I like how this models "immutability" in terms of the exact transitions allowed.
/hold to give @deads2k and @sttts a chance to weigh in

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaron-prindle, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

@yongruilin yongruilin Awaiting requested review from yongruilin

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaron-prindle @k8s-ci-robot @jpbetz @deads2k