Skip to content

KEP-5278: update PRR review questionnaire for move to beta #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

KEP-5278: update PRR review questionnaire for move to beta #5618

wants to merge 2 commits into from
+6 −4

Conversation

ania-borowiec
Copy link

  • One-line PR description: Update PRR review questionaire to reflect state upon graduating to beta
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Oct 6, 2025
@k8s-ci-robot k8s-ci-robot requested review from dom4ha and macsko October 6, 2025 10:09
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2025
@ania-borowiec
Copy link
Author

/cc @dom4ha @sanposhiho @macsko

@macsko
Copy link
Member

macsko commented Oct 6, 2025

/hold
Waiting for the rest of updates for v1.35

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2025
soltysh
soltysh reviewed Oct 7, 2025
View reviewed changes
keps/sig-scheduling/5278-nominated-node-name-for-expectation/kep.yaml
stage: alpha

latest-milestone: "v1.34"
latest-milestone: "v1.35"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #5278 (comment) it seems you're moving this to beta. In this case please don't forget to update https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-scheduling/5278.yaml, I'll handle the PRR for this PR like the last time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reminder, I updated the file.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ania-borowiec
Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh left review comments

@dom4ha dom4ha Awaiting requested review from dom4ha

@macsko macsko Awaiting requested review from macsko

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Scheduling
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ania-borowiec @macsko @k8s-ci-robot @soltysh