Skip to content

KEP-5278: update PRR review questionnaire for move to beta #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −4
Open

KEP-5278: update PRR review questionnaire for move to beta #5618

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0bce5c
prr questionnaire updated
ania-borowiec Oct 6, 2025
e0345cd
prr approver updated
ania-borowiec Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions keps/sig-scheduling/5278-nominated-node-name-for-expectation/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ Pods that are processed by Permit or PreBind plugins get NominatedNodeName durin
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?

Yes.
The feature can be disabled in Alpha version by restarting the kube-scheduler and kube-apiserver with the feature-gate off.
The feature can be disabled in Beta version by restarting the kube-scheduler and kube-apiserver with the feature-gate off.

###### What happens if we reenable the feature if it was previously rolled back?

Expand Down Expand Up @@ -752,8 +752,8 @@ No.
###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?

Yes - but it should be negligible impact.
The memory usage in kube-scheduler is supposed to increase by external components starting to use this
because when `NominatedNodeName` is added on the pods, the scheduler's internal component called `nominator` has to record them so that scheduling cycles can refer to them as necessary.
The memory usage in kube-scheduler is supposed to increase because when `NominatedNodeName` is added on the pods, the scheduler's
internal component called `nominator` has to record them so that scheduling cycles can refer to them as necessary.

###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

Expand Down
2 changes: 1 addition & 1 deletion keps/sig-scheduling/5278-nominated-node-name-for-expectation/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ approvers:

stage: alpha

latest-milestone: "v1.34"
latest-milestone: "v1.35"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #5278 (comment) it seems you're moving this to beta. In this case please don't forget to update https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-scheduling/5278.yaml, I'll handle the PRR for this PR like the last time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reminder, I updated the file.


milestone:
alpha: "v1.34"
Expand Down