Skip to content

Performance: Use FormatOnly on imports #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2024
+20 −6
Merged

Performance: Use FormatOnly on imports #277

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13ad52c
Disable the insertion and deletion of imports
jpbetz Aug 29, 2024
df35488
Avoid imports of same name
jpbetz Sep 2, 2024
4ef5de9
Update local package test to match behavior change
jpbetz Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion v2/generator/execute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"strings"

"golang.org/x/tools/imports"

"k8s.io/gengo/v2/namer"
"k8s.io/gengo/v2/types"
"k8s.io/klog/v2"
Expand Down Expand Up @@ -114,7 +115,13 @@ func assembleGoFile(w io.Writer, f *File) {
}

func importsWrapper(src []byte) ([]byte, error) {
return imports.Process("", src, nil)
opt := imports.Options{
Comments: true,
TabIndent: true,
TabWidth: 8,
FormatOnly: true, // Disable the insertion and deletion of imports
}
return imports.Process("", src, &opt)
}

func NewGoFile() *DefaultFileType {
Expand Down