-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Clean out Ingress field in store.Lister struct #9537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @dud225. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@dud225 Can you please rebase over main, and retest? Thanks! |
d14c324 to
3e1f280
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dud225 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3e1f280 to
443ede3
Compare
|
@rikatz done |
|
hum I think the rebase didn't worked, the label is still there conflicting. |
This field isn't used anywhere. The ingresses are actually stored alongside their parsed annotations in the IngressWithAnnotation field. Signed-off-by: Hervé Werner <[email protected]>
443ede3 to
aa41061
Compare
|
@rikatz I've rebased again over main it should be good now 🙏 |
|
@dud225 can you rebase and retest for us, trying to clean up open issues and PRs |
|
/uncc |
This field isn't used anywhere. The ingresses are actually stored
alongside their parsed annotations in the IngressWithAnnotation field.