Skip to content

Conversation

@dud225
Copy link
Contributor

@dud225 dud225 commented Jan 23, 2023

This field isn't used anywhere. The ingresses are actually stored
alongside their parsed annotations in the IngressWithAnnotation field.

@k8s-ci-robot k8s-ci-robot requested a review from rikatz January 23, 2023 15:11
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 23, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 23, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dud225. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2023
@rikatz
Copy link
Member

rikatz commented Jan 23, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2023
@rikatz
Copy link
Member

rikatz commented Feb 27, 2024

@dud225 Can you please rebase over main, and retest?

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dud225
Once this PR has been reviewed and has the lgtm label, please assign tao12345666333 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2024
@netlify
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for kubernetes-ingress-nginx ready!

Name Link
🔨 Latest commit aa41061
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65e05bd7d4d1a6000898cb70
😎 Deploy Preview https://deploy-preview-9537--kubernetes-ingress-nginx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dud225
Copy link
Contributor Author

dud225 commented Feb 28, 2024

@rikatz done

@rikatz
Copy link
Member

rikatz commented Feb 28, 2024

hum I think the rebase didn't worked, the label is still there conflicting.

@rikatz rikatz added this to the release-1.11 milestone Feb 28, 2024
This field isn't used anywhere. The ingresses are actually stored
alongside their parsed annotations in the IngressWithAnnotation field.

Signed-off-by: Hervé Werner <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2024
@dud225
Copy link
Contributor Author

dud225 commented Feb 29, 2024

@rikatz I've rebased again over main it should be good now 🙏

@strongjz
Copy link
Member

@dud225 can you rebase and retest for us, trying to clean up open issues and PRs

@rikatz
Copy link
Member

rikatz commented Aug 15, 2025

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from rikatz August 15, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants