Skip to content

Create new External-Provisioner AR registry #8386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −0
Closed

Create new External-Provisioner AR registry #8386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions infra/gcp/terraform/k8s-staging-images/registries.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ locals {
secrets-store-sync = "group:[email protected]"
test-infra = "group:[email protected]"
csi-vsphere = "group:[email protected]"
external-provisioner = "group:[email protected]"
Copy link
Contributor

@xing-yang xing-yang Aug 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have lots of repos under https://github.com/kubernetes-csi/. external-provisioner is just one of the repos: https://github.com/kubernetes-csi/external-provisioner. Do we need to add a line here for every repo? Should we just add one registry for all repos under kubernetes-csi?

Copy link
Member

@upodroid upodroid Aug 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you need to create an entry for each repository and have a dedicated image manifests for each one and promote them separately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we will have something like this?
external-provisioner = "group:[email protected]"
external-attacher = "group:[email protected]"
external-snapshotter = "group:[email protected]"
external-provisioner = "group:[email protected]"
external-resizer = "group:[email protected]"
external-provisioner = "group:[email protected]"
.......
There will be about 17 entries?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is it possible to use one registry for all the repos under https://github.com/kubernetes-csi/ org?

Copy link
Member

@upodroid upodroid Aug 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we already have a top level csi registry at registry.k8s.io/csi.

https://explore.ggcr.dev/?repo=registry.k8s.io%2Fcsi

Do you want to use that to hold the images from the csi GitHub org?

Also, what about registry.k8s.io/sig-storage https://explore.ggcr.dev/?repo=registry.k8s.io%2Fsig-storage?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can use the top level csi registry.
We need registries for both csi repos and sig-storage. Other than kubernetes-csi, we also have multiple repos under kubernetes-sigs. Those can use the sig-storage registry.

}

# Only registries used internally by CI should be listed here
Expand Down