Merge pull request #2046 from juanjjaramillo/juanjjaramillo/fix_job_failure_reason

k8s-ci-robot · web-flow · commit 168254d64c0b · 2023-04-14T10:18:41.000-07:00
Fix casing while scraping failure reason for `kube_job_status_failed`
diff --git a/internal/store/job.go b/internal/store/job.go
@@ -39,7 +39,7 @@ var (
 	descJobLabelsName          = "kube_job_labels"
 	descJobLabelsHelp          = "Kubernetes labels converted to Prometheus labels."
 	descJobLabelsDefaultLabels = []string{"namespace", "job_name"}
-	jobFailureReasons          = []string{"BackoffLimitExceeded", "DeadLineExceeded", "Evicted"}
+	jobFailureReasons          = []string{"BackoffLimitExceeded", "DeadlineExceeded", "Evicted"}
 )
 
 func jobMetricFamilies(allowAnnotationsList, allowLabelsList []string) []generator.FamilyGenerator {
diff --git a/internal/store/job_test.go b/internal/store/job_test.go
@@ -210,7 +210,7 @@ func TestJobStore(t *testing.T) {
 				kube_job_status_active{job_name="FailedJob1",namespace="ns1"} 0
 				kube_job_status_completion_time{job_name="FailedJob1",namespace="ns1"} 1.495810807e+09
 				kube_job_status_failed{job_name="FailedJob1",namespace="ns1",reason="BackoffLimitExceeded"} 1
-				kube_job_status_failed{job_name="FailedJob1",namespace="ns1",reason="DeadLineExceeded"} 0
+				kube_job_status_failed{job_name="FailedJob1",namespace="ns1",reason="DeadlineExceeded"} 0
 				kube_job_status_failed{job_name="FailedJob1",namespace="ns1",reason="Evicted"} 0
 				kube_job_status_start_time{job_name="FailedJob1",namespace="ns1"} 1.495807207e+09
 				kube_job_status_succeeded{job_name="FailedJob1",namespace="ns1"} 0

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ var (`
`39`	`39`	`descJobLabelsName = "kube_job_labels"`
`40`	`40`	`descJobLabelsHelp = "Kubernetes labels converted to Prometheus labels."`
`41`	`41`	`descJobLabelsDefaultLabels = []string{"namespace", "job_name"}`
`42`		`- jobFailureReasons = []string{"BackoffLimitExceeded", "DeadLineExceeded", "Evicted"}`
	`42`	`+ jobFailureReasons = []string{"BackoffLimitExceeded", "DeadlineExceeded", "Evicted"}`
`43`	`43`	`)`
`44`	`44`
`45`	`45`	`func jobMetricFamilies(allowAnnotationsList, allowLabelsList []string) []generator.FamilyGenerator {`