-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Add actual pod resources metrics #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Welcome @wardady! |
/triage accepted |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wardady The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dgrisonnet @logicalhan I adjusted the failing test and now it passes locally. Could you please approve the CI run? |
@dgrisonnet @logicalhan would appreciate any review or feedback on this PR. |
What this PR does / why we need it:
Starting from Kubernetes 1.33,
kube_pod_container_resource_requests
andkube_pod_container_actual_resource_limits
reflect the desired state of the container resource requests/limits.This PR adds 2 new metric families:
kube_pod_container_actual_resource_requests
andkube_pod_container_actual_resource_limits
that expose values fromstatus.containerStatuses[i].resources
and reflect the current actual requests and limits of each container.How does this change affect the cardinality of KSM:
The PR adds 2 new metric families with the same cardinality as very similar already existing metric families.
Which issue(s) this PR fixes
Fixes #2665