add kube_deployment_status_replicas_terminating and kube_replicaset_status_terminating_replicas metrics #2708
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: atiratree The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-triage
Bumps the k8s-dependencies group with 5 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.3` | `0.33.0` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.32.3` | `0.33.0` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.3` | `0.33.0` | | [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.32.3` | `0.33.0` | | [k8s.io/sample-controller](https://github.com/kubernetes/sample-controller) | `0.32.3` | `0.33.0` | Updates `k8s.io/api` from 0.32.3 to 0.33.0 - [Commits](kubernetes/api@v0.32.3...v0.33.0) Updates `k8s.io/apimachinery` from 0.32.3 to 0.33.0 - [Commits](kubernetes/apimachinery@v0.32.3...v0.33.0) Updates `k8s.io/client-go` from 0.32.3 to 0.33.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.3...v0.33.0) Updates `k8s.io/component-base` from 0.32.3 to 0.33.0 - [Commits](kubernetes/component-base@v0.32.3...v0.33.0) Updates `k8s.io/sample-controller` from 0.32.3 to 0.33.0 - [Commits](kubernetes/sample-controller@v0.32.3...v0.33.0) --- updated-dependencies: - dependency-name: k8s.io/api dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/client-go dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/component-base dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/sample-controller dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…tatus_terminating_replicas metrics
atiratree
force-pushed
the
terminating-replicas-rs-deploy
branch
from
6eb6e66 to
0785f33
Compare
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
Error: ../../../go/pkg/mod/k8s.io/[email protected]/pkg/cel/environment/base.go:53:30: undefined: featuregate.DefaultComponentGlobalsRegistry Could you upgrade k8s version in a separate pull request? |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This is needed to support the kubernetes/enhancements#3973 observability and to promote DeploymentReplicaSetTerminatingReplicas to Beta kubernetes/kubernetes#133087
Requires: #2664
How does this change affect the cardinality of KSM: increases
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #