Skip to content

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 5, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Verify/test latest etcd patch v3.6.5 in workflow

Which issue(s) this PR is related to:

etcd-io/etcd#20501

Does this PR introduce a user-facing change?

updated etcd to v3.6.5.

cc @hakman @ivanvc @joshjms

Signed-off-by: Benjamin Wang <[email protected]>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 5, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Oct 5, 2025
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2025
@k8s-ci-robot
Copy link
Contributor

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process.

If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 5, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from bowei and mkumatag October 5, 2025 18:15
@ahrtr
Copy link
Member Author

ahrtr commented Oct 5, 2025

Link to #134251

cc @dims @neolit123

@ahrtr
Copy link
Member Author

ahrtr commented Oct 5, 2025

/test pull-kubernetes-e2e-gce

@hakman
Copy link
Member

hakman commented Oct 5, 2025

@ahrtr @joshjms I think #134268 needs to be cherrypicked first/also.
Similar for any other K8s release where the official images will be used.

@ahrtr
Copy link
Member Author

ahrtr commented Oct 5, 2025

@ahrtr @joshjms I think #134268 needs to be cherrypicked first/also. Similar for any other K8s release where the official images will be used.

thx. @joshjms do you have bandwidth to backport the PR? If not, I will take care of it tomorrow my time.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 6, 2025
@ahrtr
Copy link
Member Author

ahrtr commented Oct 6, 2025

@ahrtr @joshjms I think #134268 needs to be cherrypicked first/also. Similar for any other K8s release where the official images will be used.

thx. @joshjms do you have bandwidth to backport the PR? If not, I will take care of it tomorrow my time.

Manually cherry picked #134431

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, neolit123
Once this PR has been reviewed and has the lgtm label, please assign dims for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c5d5ff92dd16f2f1baa274c87e39b00dc067fa0

@neolit123
Copy link
Member

/release-note-none

release notes are required when bumping component versions
i edited the original PR, but can't do it here.

#134251 (comment)

@ahrtr
Copy link
Member Author

ahrtr commented Oct 6, 2025

/lgtm /approve /retest

thx. We need to merge #134431 to resolve the workflow failure.

@ahrtr
Copy link
Member Author

ahrtr commented Oct 6, 2025

/release-note-edit

updated etcd to v3.6.5.

@k8s-ci-robot
Copy link
Contributor

@ahrtr: /release-note-edit must be used with a release note block.

In response to this:

/release-note-edit

updated etcd to v3.6.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@ahrtr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce 28e3d1e link true /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Oct 7, 2025

/hold while clarifying Windows support

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2025
@ahrtr
Copy link
Member Author

ahrtr commented Oct 7, 2025

kubernetes/k8s.io#8596 (comment)

Windows is just tier-3 support, see https://etcd.io/docs/v3.6/op-guide/supported-platform/. Currently we (etcd team) only build linux container images.

$ docker manifest inspect gcr.io/etcd-development/etcd:v3.6.5
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 3650,
         "digest": "sha256:28cf8781a30d69c2e3a969764548497a949a363840e1de34e014608162644778",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 3650,
         "digest": "sha256:0f87957e19b97d01b2c70813ee5c4949f8674deac4a65f7167c4cd85f7f2941e",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 3650,
         "digest": "sha256:2055881a1107b7e1bf7002b48544aed8b7da517d4d8e138c7b3b67abbf73a81d",
         "platform": {
            "architecture": "ppc64le",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 3650,
         "digest": "sha256:dfecf781891d331534930c82444272582feb768fb07b51a0cc1e51d7ebbbc170",
         "platform": {
            "architecture": "s390x",
            "os": "linux"
         }
      }
   ]
}

@marosset mentioned in above comment that Windows images are used in some e2e tests, but why we did not see any workflow failures so far? @hakman @joshjms

@marosset could you please clarify which e2e test you were referring to? AFAIK, Kubernetes doesn't support deploying the control plane on Windows.

cc @dims @neolit123

@neolit123
Copy link
Member

neolit123 commented Oct 7, 2025

i think what happened is that the api machinery test was added by mistake to windows conformance, instead of excluding it as LinuxOnly. that was done by making it pass via the included windows etcd in the image. there might be more similar tests.

my vote is to just tag them as LnuxOnly, but the bigger question is whether this inclusion of the windows binary resulted in ecosystem usage e.g. someone running etcd on distributed windows server instances for HA. that is not the same as running a windows control plane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants