-
Notifications
You must be signed in to change notification settings - Fork 41.5k
[release-1.34] etcd: bump etcd to v3.6.5 #134426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.34
Are you sure you want to change the base?
Conversation
Signed-off-by: Benjamin Wang <[email protected]>
This cherry pick PR is for a release branch and has not yet been approved by Release Managers. To merge this cherry pick, it must first be approved ( If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process. If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document. AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers (This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.) For details on the patch release process and schedule, see the Patch Releases page. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Link to #134251 cc @dims @neolit123 |
/test pull-kubernetes-e2e-gce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ahrtr, neolit123 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 5c5d5ff92dd16f2f1baa274c87e39b00dc067fa0
|
release notes are required when bumping component versions |
thx. We need to merge #134431 to resolve the workflow failure. |
/release-note-edit
|
@ahrtr: /release-note-edit must be used with a release note block. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ahrtr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold while clarifying Windows support |
Windows is just tier-3 support, see https://etcd.io/docs/v3.6/op-guide/supported-platform/. Currently we (etcd team) only build linux container images.
@marosset mentioned in above comment that Windows images are used in some e2e tests, but why we did not see any workflow failures so far? @hakman @joshjms @marosset could you please clarify which e2e test you were referring to? AFAIK, Kubernetes doesn't support deploying the control plane on Windows. cc @dims @neolit123 |
i think what happened is that the api machinery test was added by mistake to windows conformance, instead of excluding it as LinuxOnly. that was done by making it pass via the included windows etcd in the image. there might be more similar tests. my vote is to just tag them as LnuxOnly, but the bigger question is whether this inclusion of the windows binary resulted in ecosystem usage e.g. someone running etcd on distributed windows server instances for HA. that is not the same as running a windows control plane. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Verify/test latest etcd patch v3.6.5 in workflow
Which issue(s) this PR is related to:
etcd-io/etcd#20501
Does this PR introduce a user-facing change?
cc @hakman @ivanvc @joshjms