kubernetes · zarenner · Apr 16, 2021 · May 26, 2021 · May 27, 2021 · medyagh
diff --git a/cmd/minikube/cmd/start_flags.go b/cmd/minikube/cmd/start_flags.go
@@ -118,6 +118,7 @@ const (
 	defaultSSHUser          = "root"
 	defaultSSHPort          = 22
 	listenAddress           = "listen-address"
+	vmwareNetworkType       = "vmware-network-type"
 )
 
 var (
@@ -220,6 +221,9 @@ func initDriverFlags() {
 	// docker & podman
 	startCmd.Flags().String(listenAddress, "", "IP Address to use to expose ports (docker and podman driver only)")
 	startCmd.Flags().StringSlice(ports, []string{}, "List of ports that should be exposed (docker and podman driver only)")
+
+	// vmware
+	startCmd.Flags().String(vmwareNetworkType, "nat", "Network connection type to use. One of 'nat', 'bridged', 'hostonly', 'custom' (vmware driver only)")
 }
 
 // initNetworkingFlags inits the commandline flags for connectivity related flags for start
@@ -418,6 +422,7 @@ func generateNewConfigFromFlags(cmd *cobra.Command, k8sVersion string, drvName s
 		SSHUser:                 viper.GetString(sshSSHUser),
 		SSHKey:                  viper.GetString(sshSSHKey),
 		SSHPort:                 viper.GetInt(sshSSHPort),
+		VMWareNetworkType:       viper.GetString(vmwareNetworkType),
 		KubernetesConfig: config.KubernetesConfig{
 			KubernetesVersion:      k8sVersion,
 			ClusterName:            ClusterFlagValue(),

diff --git a/pkg/minikube/config/types.go b/pkg/minikube/config/types.go
@@ -82,6 +82,7 @@ type ClusterConfig struct {
 	ExposedPorts            []string // Only used by the docker and podman driver
 	ListenAddress           string   // Only used by the docker and podman driver
 	Network                 string   // only used by docker driver
+	VMWareNetworkType       string   // Only used by vmware driver
 	MultiNodeRequested      bool
 }
 

diff --git a/pkg/minikube/registry/drvs/vmware/vmware.go b/pkg/minikube/registry/drvs/vmware/vmware.go
@@ -47,6 +47,7 @@ func configure(cc config.ClusterConfig, n config.Node) (interface{}, error) {
 	d.Memory = cc.Memory
 	d.CPU = cc.CPUs
 	d.DiskSize = cc.DiskSize
+	d.NetworkType = cc.VMWareNetworkType
 
 	// TODO(frapposelli): push these defaults upstream to fixup this driver
 	d.SSHPort = 22

diff --git a/site/content/en/docs/commands/start.md b/site/content/en/docs/commands/start.md
@@ -98,6 +98,7 @@ minikube start [flags]
       --uuid string                       Provide VM UUID to restore MAC address (hyperkit driver only)
       --vm                                Filter to use only VM Drivers
       --vm-driver driver                  DEPRECATED, use driver instead.
+      --vmware-network-type string        Network connection type to use. One of 'nat', 'bridged', 'hostonly', 'custom' (vmware driver only) (default "nat")
       --wait strings                      comma separated list of Kubernetes components to verify and wait for after starting a cluster. defaults to "apiserver,system_pods", available options: "apiserver,system_pods,default_sa,apps_running,node_ready,kubelet" . other acceptable values are 'all' or 'none', 'true' and 'false' (default [apiserver,system_pods])
       --wait-timeout duration             max time to wait per Kubernetes or host to be healthy. (default 6m0s)
 ```

diff --git a/site/content/en/docs/contrib/errorcodes.en.md b/site/content/en/docs/contrib/errorcodes.en.md
@@ -285,6 +285,10 @@ minikube has no current cluster running
 
 "DRV_NOT_DETECTED" (Exit code ExDriverNotFound)  
 
+"DRV_NOT_HEALTHY" (Exit code ExDriverNotFound)  
+
+"DRV_DOCKER_NOT_RUNNING" (Exit code ExDriverNotFound)  
+
 "DRV_AS_ROOT" (Exit code ExDriverPermission)  
 
 "DRV_NEEDS_ROOT" (Exit code ExDriverPermission)  
@@ -329,6 +333,8 @@ minikube has no current cluster running
 
 "GUEST_PROVISION" (Exit code ExGuestError)  
 
+"GUEST_PROVISION_CONTAINER_EXITED" (Exit code ExGuestError)  
+
 "GUEST_START" (Exit code ExGuestError)  
 
 "GUEST_STATUS" (Exit code ExGuestError)  

diff --git a/site/content/en/docs/drivers/vmware.md b/site/content/en/docs/drivers/vmware.md
@@ -21,6 +21,12 @@ No documentation is available yet.
 {{% /windowstab %}}
 {{% /tabs %}}
 
+## Special features
+
+minikube start supports some VMWare specific flags:
+
+* **`--vmware-network-type`**: Network connection type to use. One of 'nat', 'bridged', 'hostonly', 'custom'. This affects the "Network Adapter" settings inside the VMWare VM.
+
 ## Issues
 
 * [Full list of open 'vmware-driver' issues](https://github.com/kubernetes/minikube/labels/co%2Fvmware-driver)

diff --git a/translations/de.json b/translations/de.json
@@ -138,6 +138,7 @@
 	"Docker Desktop is configured for Windows containers, but Linux containers are required for minikube": "",
 	"Docker Desktop only has {{.size}}MiB available, less than the required {{.req}}MiB for Kubernetes": "",
 	"Docker Desktop only has {{.size}}MiB available, you may encounter application deployment failures.": "",
+	"Docker container exited prematurely after it was created, consider investigating Docker's performance/health.": "",
 	"Docker has less than 2 CPUs available, but Kubernetes requires at least 2 to be available": "",
 	"Docker inside the VM is unavailable. Try running 'minikube delete' to reset the VM.": "",
 	"Docs have been saved at - {{.path}}": "",
@@ -226,7 +227,6 @@
 	"Failed to change permissions for {{.minikube_dir_path}}: {{.error}}": "Fehler beim Ändern der Berechtigungen für {{.minikube_dir_path}}: {{.error}}",
 	"Failed to check main repository and mirrors for images": "",
 	"Failed to configure metallb IP {{.profile}}": "",
-	"Failed to copying file": "",
 	"Failed to create file": "",
 	"Failed to delete cluster {{.name}}, proceeding with retry anyway.": "",
 	"Failed to delete cluster {{.name}}.": "",
@@ -274,6 +274,8 @@
 	"Force environment to be configured for a specified shell: [fish, cmd, powershell, tcsh, bash, zsh], default is auto-detect": "",
 	"Force minikube to perform possibly dangerous operations": "minikube zwingen, möglicherweise gefährliche Operationen durchzuführen",
 	"Format to print stdout in. Options include: [text,json]": "",
+	"Found docker, but the docker service isn't running. Try restarting the docker service.": "",
+	"Found driver(s) but none were healthy. See above for suggestions how to fix installed drivers.": "",
 	"Found network options:": "Gefundene Netzwerkoptionen:",
 	"Found {{.number}} invalid profile(s) ! ": "",
 	"Generate command completion for a shell": "",
@@ -375,6 +377,7 @@
 	"NIC Type used for host only network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NIC Type used for nat network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NOTE: This process must stay alive for the mount to be accessible ...": "",
+	"Network connection type to use. One of 'nat', 'bridged', 'hostonly', 'custom' (vmware driver only)": "",
 	"Networking and Connectivity Commands:": "",
 	"No IP address provided. Try specifying --ssh-ip-address, or see https://minikube.sigs.k8s.io/docs/drivers/ssh/": "",
 	"No changes required for the \"{{.context}}\" context": "",

diff --git a/translations/es.json b/translations/es.json
@@ -139,6 +139,7 @@
 	"Docker Desktop is configured for Windows containers, but Linux containers are required for minikube": "Docker Desktop necesita estar configurado para contenedores Linux para poder usar minikube",
 	"Docker Desktop only has {{.size}}MiB available, less than the required {{.req}}MiB for Kubernetes": "Docker Desktop tiene solo {{.size}}MiB disponibles, menos que los {{.req}}MiB requeridos por Kubernetes",
 	"Docker Desktop only has {{.size}}MiB available, you may encounter application deployment failures.": "Docker Desktop tiene solo {{.size}}MiB disponibles, puede que encuentres fallas en tus deployments de aplicaciones",
+	"Docker container exited prematurely after it was created, consider investigating Docker's performance/health.": "",
 	"Docker has less than 2 CPUs available, but Kubernetes requires at least 2 to be available": "Docker tiene menos de 2 CPUs disponibles, pero Kubernetes requiere al menos 2 para estar disponible",
 	"Docker inside the VM is unavailable. Try running 'minikube delete' to reset the VM.": "No está disponible Docker dentro de la VM. Intenta usar 'minikube delete' para reestablecer la VM.",
 	"Docs have been saved at - {{.path}}": "La documentación ha sido guardada en - {{.path}}",
@@ -231,7 +232,6 @@
 	"Failed to change permissions for {{.minikube_dir_path}}: {{.error}}": "No se han podido cambiar los permisos de {{.minikube_dir_path}}: {{.error}}",
 	"Failed to check main repository and mirrors for images": "",
 	"Failed to configure metallb IP {{.profile}}": "",
-	"Failed to copying file": "",
 	"Failed to create file": "",
 	"Failed to delete cluster {{.name}}, proceeding with retry anyway.": "",
 	"Failed to delete cluster {{.name}}.": "",
@@ -279,6 +279,8 @@
 	"Force environment to be configured for a specified shell: [fish, cmd, powershell, tcsh, bash, zsh], default is auto-detect": "",
 	"Force minikube to perform possibly dangerous operations": "Permite forzar minikube para que realice operaciones potencialmente peligrosas",
 	"Format to print stdout in. Options include: [text,json]": "",
+	"Found docker, but the docker service isn't running. Try restarting the docker service.": "",
+	"Found driver(s) but none were healthy. See above for suggestions how to fix installed drivers.": "",
 	"Found network options:": "Se han encontrado las siguientes opciones de red:",
 	"Found {{.number}} invalid profile(s) ! ": "",
 	"Generate command completion for a shell": "",
@@ -380,6 +382,7 @@
 	"NIC Type used for host only network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NIC Type used for nat network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NOTE: This process must stay alive for the mount to be accessible ...": "",
+	"Network connection type to use. One of 'nat', 'bridged', 'hostonly', 'custom' (vmware driver only)": "",
 	"Networking and Connectivity Commands:": "",
 	"No IP address provided. Try specifying --ssh-ip-address, or see https://minikube.sigs.k8s.io/docs/drivers/ssh/": "",
 	"No changes required for the \"{{.context}}\" context": "",

diff --git a/translations/fr.json b/translations/fr.json
@@ -140,6 +140,7 @@
 	"Docker Desktop is configured for Windows containers, but Linux containers are required for minikube": "",
 	"Docker Desktop only has {{.size}}MiB available, less than the required {{.req}}MiB for Kubernetes": "",
 	"Docker Desktop only has {{.size}}MiB available, you may encounter application deployment failures.": "",
+	"Docker container exited prematurely after it was created, consider investigating Docker's performance/health.": "",
 	"Docker has less than 2 CPUs available, but Kubernetes requires at least 2 to be available": "",
 	"Docker inside the VM is unavailable. Try running 'minikube delete' to reset the VM.": "",
 	"Docs have been saved at - {{.path}}": "",
@@ -228,7 +229,6 @@
 	"Failed to change permissions for {{.minikube_dir_path}}: {{.error}}": "Échec de la modification des autorisations pour {{.minikube_dir_path}} : {{.error}}",
 	"Failed to check main repository and mirrors for images": "",
 	"Failed to configure metallb IP {{.profile}}": "",
-	"Failed to copying file": "",
 	"Failed to create file": "",
 	"Failed to delete cluster {{.name}}, proceeding with retry anyway.": "",
 	"Failed to delete cluster {{.name}}.": "",
@@ -276,6 +276,8 @@
 	"Force environment to be configured for a specified shell: [fish, cmd, powershell, tcsh, bash, zsh], default is auto-detect": "",
 	"Force minikube to perform possibly dangerous operations": "Oblige minikube à réaliser des opérations possiblement dangereuses.",
 	"Format to print stdout in. Options include: [text,json]": "",
+	"Found docker, but the docker service isn't running. Try restarting the docker service.": "",
+	"Found driver(s) but none were healthy. See above for suggestions how to fix installed drivers.": "",
 	"Found network options:": "Options de réseau trouvées :",
 	"Found {{.number}} invalid profile(s) ! ": "",
 	"Generate command completion for a shell": "",
@@ -377,6 +379,7 @@
 	"NIC Type used for host only network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NIC Type used for nat network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NOTE: This process must stay alive for the mount to be accessible ...": "",
+	"Network connection type to use. One of 'nat', 'bridged', 'hostonly', 'custom' (vmware driver only)": "",
 	"Networking and Connectivity Commands:": "",
 	"No IP address provided. Try specifying --ssh-ip-address, or see https://minikube.sigs.k8s.io/docs/drivers/ssh/": "",
 	"No changes required for the \"{{.context}}\" context": "",

diff --git a/translations/ja.json b/translations/ja.json
@@ -135,6 +135,7 @@
 	"Docker Desktop is configured for Windows containers, but Linux containers are required for minikube": "",
 	"Docker Desktop only has {{.size}}MiB available, less than the required {{.req}}MiB for Kubernetes": "",
 	"Docker Desktop only has {{.size}}MiB available, you may encounter application deployment failures.": "",
+	"Docker container exited prematurely after it was created, consider investigating Docker's performance/health.": "",
 	"Docker has less than 2 CPUs available, but Kubernetes requires at least 2 to be available": "",
 	"Docker inside the VM is unavailable. Try running 'minikube delete' to reset the VM.": "",
 	"Docs have been saved at - {{.path}}": "ドキュメントは以下のパスに保存されました。{{.path}}",
@@ -218,7 +219,6 @@
 	"Failed to change permissions for {{.minikube_dir_path}}: {{.error}}": "{{.minikube_dir_path}} に対する権限を変更できませんでした。{{.error}}",
 	"Failed to check main repository and mirrors for images": "",
 	"Failed to configure metallb IP {{.profile}}": "",
-	"Failed to copying file": "",
 	"Failed to create file": "",
 	"Failed to delete cluster {{.name}}, proceeding with retry anyway.": "クラスタを削除できませんでしたが、処理を続行します。",
 	"Failed to delete cluster {{.name}}.": "",
@@ -264,6 +264,8 @@
 	"Force environment to be configured for a specified shell: [fish, cmd, powershell, tcsh, bash, zsh], default is auto-detect": "",
 	"Force minikube to perform possibly dangerous operations": "minikube で危険な可能性のある操作を強制的に実行します",
 	"Format to print stdout in. Options include: [text,json]": "",
+	"Found docker, but the docker service isn't running. Try restarting the docker service.": "",
+	"Found driver(s) but none were healthy. See above for suggestions how to fix installed drivers.": "",
 	"Found network options:": "ネットワーク オプションが見つかりました",
 	"Found {{.number}} invalid profile(s) ! ": "",
 	"Generate command completion for a shell": "シェルのコマンド補完コードを生成します",
@@ -368,6 +370,7 @@
 	"NIC Type used for host only network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NIC Type used for nat network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NOTE: This process must stay alive for the mount to be accessible ...": "",
+	"Network connection type to use. One of 'nat', 'bridged', 'hostonly', 'custom' (vmware driver only)": "",
 	"Networking and Connectivity Commands:": "ネットワーキング及び接続性コマンド:",
 	"No IP address provided. Try specifying --ssh-ip-address, or see https://minikube.sigs.k8s.io/docs/drivers/ssh/": "",
 	"No changes required for the \"{{.context}}\" context": "",

diff --git a/translations/ko.json b/translations/ko.json
@@ -148,6 +148,7 @@
 	"Docker Desktop is configured for Windows containers, but Linux containers are required for minikube": "",
 	"Docker Desktop only has {{.size}}MiB available, less than the required {{.req}}MiB for Kubernetes": "",
 	"Docker Desktop only has {{.size}}MiB available, you may encounter application deployment failures.": "",
+	"Docker container exited prematurely after it was created, consider investigating Docker's performance/health.": "",
 	"Docker has less than 2 CPUs available, but Kubernetes requires at least 2 to be available": "",
 	"Docker inside the VM is unavailable. Try running 'minikube delete' to reset the VM.": "",
 	"Docs have been saved at - {{.path}}": "문서가 다음 경로에 저장되었습니다 - {{.path}}",
@@ -246,7 +247,6 @@
 	"Failed to check if machine exists": "머신이 존재하는지 확인하는 데 실패하였습니다",
 	"Failed to check main repository and mirrors for images": "",
 	"Failed to configure metallb IP {{.profile}}": "",
-	"Failed to copying file": "",
 	"Failed to create file": "",
 	"Failed to delete cluster {{.name}}, proceeding with retry anyway.": "",
 	"Failed to delete cluster {{.name}}.": "",
@@ -296,6 +296,8 @@
 	"Force environment to be configured for a specified shell: [fish, cmd, powershell, tcsh, bash, zsh], default is auto-detect": "",
 	"Force minikube to perform possibly dangerous operations": "",
 	"Format to print stdout in. Options include: [text,json]": "",
+	"Found docker, but the docker service isn't running. Try restarting the docker service.": "",
+	"Found driver(s) but none were healthy. See above for suggestions how to fix installed drivers.": "",
 	"Found network options:": "네트워크 옵션을 찾았습니다",
 	"Found {{.number}} invalid profile(s) !": "{{.number}} 개의 무효한 프로필을 찾았습니다",
 	"Found {{.number}} invalid profile(s) ! ": "",
@@ -399,6 +401,7 @@
 	"NIC Type used for host only network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NIC Type used for nat network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NOTE: This process must stay alive for the mount to be accessible ...": "",
+	"Network connection type to use. One of 'nat', 'bridged', 'hostonly', 'custom' (vmware driver only)": "",
 	"Networking and Connectivity Commands:": "",
 	"No IP address provided. Try specifying --ssh-ip-address, or see https://minikube.sigs.k8s.io/docs/drivers/ssh/": "",
 	"No changes required for the \"{{.context}}\" context": "",

diff --git a/translations/pl.json b/translations/pl.json
@@ -148,6 +148,7 @@
 	"Docker Desktop is configured for Windows containers, but Linux containers are required for minikube": "",
 	"Docker Desktop only has {{.size}}MiB available, less than the required {{.req}}MiB for Kubernetes": "",
 	"Docker Desktop only has {{.size}}MiB available, you may encounter application deployment failures.": "",
+	"Docker container exited prematurely after it was created, consider investigating Docker's performance/health.": "",
 	"Docker has less than 2 CPUs available, but Kubernetes requires at least 2 to be available": "",
 	"Docker inside the VM is unavailable. Try running 'minikube delete' to reset the VM.": "",
 	"Docs have been saved at - {{.path}}": "Dokumentacja została zapisana w {{.path}}",
@@ -236,7 +237,6 @@
 	"Failed to change permissions for {{.minikube_dir_path}}: {{.error}}": "Nie udało się zmienić uprawnień pliku {{.minikube_dir_path}}: {{.error}}",
 	"Failed to check main repository and mirrors for images": "",
 	"Failed to configure metallb IP {{.profile}}": "",
-	"Failed to copying file": "",
 	"Failed to create file": "",
 	"Failed to delete cluster {{.name}}, proceeding with retry anyway.": "",
 	"Failed to delete cluster {{.name}}.": "",
@@ -283,6 +283,8 @@
 	"Force environment to be configured for a specified shell: [fish, cmd, powershell, tcsh, bash, zsh], default is auto-detect": "",
 	"Force minikube to perform possibly dangerous operations": "Wymuś wykonanie potencjalnie niebezpiecznych operacji",
 	"Format to print stdout in. Options include: [text,json]": "",
+	"Found docker, but the docker service isn't running. Try restarting the docker service.": "",
+	"Found driver(s) but none were healthy. See above for suggestions how to fix installed drivers.": "",
 	"Found network options:": "Wykryto opcje sieciowe:",
 	"Found {{.number}} invalid profile(s) !": "Wykryto {{.number}} nieprawidłowych profili ! ",
 	"Found {{.number}} invalid profile(s) ! ": "",
@@ -389,6 +391,7 @@
 	"NIC Type used for host only network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NIC Type used for nat network. One of Am79C970A, Am79C973, 82540EM, 82543GC, 82545EM, or virtio (virtualbox driver only)": "",
 	"NOTE: This process must stay alive for the mount to be accessible ...": "",
+	"Network connection type to use. One of 'nat', 'bridged', 'hostonly', 'custom' (vmware driver only)": "",
 	"Networking and Connectivity Commands:": "",
 	"No IP address provided. Try specifying --ssh-ip-address, or see https://minikube.sigs.k8s.io/docs/drivers/ssh/": "",
 	"No changes required for the \"{{.context}}\" context": "",