Skip Kubernetes preloads and binary downloads when --no-kubernetes is… #21107

[divysinghvi]

This PR improves the Binary function in binary.go to better handle Kubernetes binary downloads. It adds logic to skip downloads when the --no-kubernetes flag is set, ensures not downloading unnecessary downloads with version v0.0.0
Before

After

This pr Fixes the issue #21107

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: divysinghvi
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @divysinghvi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

thank you @divysinghvi please consider adding an integraiton test sub-test to

https://vscode.dev/github/kubernetes/minikube/blob/separate-hack/test/integration/no_kubernetes_test.go#L32

before {"StartNoK8sWithVersion", validateStartNoK8sWithVersion}, you can do --download-only and check using -minikube ssh -- ls path/to/binary/- that the file doesnt exist

[divysinghvi]

@medyagh Thanks for the suggestion! Just to clarify, for the integration test you mentioned, which exact Kubernetes binary path should I check for in the VM after running minikube with --no-kubernetes --download-only?
but i am confused what exact binary path should i check for

[medyagh]

Lets also try not setting k8s version to 0.0.0 and see what breaks and why did we have to that

[medyagh]

lets add a sub test that that checks this folder should not exist
~/.minikube/cache/linux/amd64/v0.0.0/

[medyagh]

ok-to-test

[medyagh]

no need to start another minikube, use the Existing started minikube and simply add a sub test
like this
{"StartNoK8sWithVersion", validateStartNoK8sWithVersion},
---> {"VerifyNok8sNoK8sDownloads", },

		{"StartWithK8s", validateStartWithK8S},
		{"StartWithStopK8s", validateStartWithStopK8s},

[divysinghvi]

since in StartNoK8sWithVersion we pass a Kubernetes version with --no-kubernetes isn't that suppose to exits with an error and that won't leave a running cluster to reuse i guess.

[divysinghvi]

maybe we are reuse this instance {"Start", validateStartNoK8S}, since it will be fresh working instance