-
Notifications
You must be signed in to change notification settings - Fork 5k
test: Initial support for virtiofs mounts #21272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
/ok-to-test |
/cc @afbjorklund |
/kind improvement |
/area mount |
/area testing |
This comment has been minimized.
This comment has been minimized.
ba2f126
to
fc50051
Compare
Rebased to consume the docker service fix |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz rebase and look at the comments
Rebased to consume #21250, comments not addressed yet. |
This comment has been minimized.
This comment has been minimized.
When testing mounts we can use findmnt --json output to parse the output cleanly. The package provides only ParseOutput() now, but it can be extended later to run the findmnt command.
Use findmnt command to get the mounted filesystem details cleanly. We use the actual mount fstype instead of driver name check so we can switch drivers to virtiofs without changing the test. For virtiofs mount we skip options validation since we don't support setting virtiofs options yet, and the options are not the same as 9p options. For 9p mounts the uid= and gid= flags were fixed to match the real flags (dfltuid=,dfltgid=). The issue was hidden by imprecise string matching.
@medyagh changes in this version:
Tested locally with vfkit and krunkit, should be ready for merge. |
kvm2 driver with docker runtime
Times for minikube start: 49.3s 46.1s 49.8s 50.3s 50.8s Times for minikube (PR 21272) ingress: 15.0s 15.0s 15.0s 15.0s 14.9s docker driver with docker runtime
Times for minikube ingress: 13.2s 12.8s 12.8s 12.8s 13.7s Times for minikube start: 23.1s 22.2s 25.3s 23.4s 22.6s docker driver with containerd runtime
Times for minikube start: 24.6s 21.6s 22.4s 22.0s 23.2s Times for minikube ingress: 23.2s 22.8s 22.7s 22.8s 39.3s |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, nirs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change prepares TestMountStart for adding virtiofs support in the drivers.
Add findmnt package for more precise mount validation and skip options validation for virtiofs mounts. Fix 9p mounts options names hidden by imprecise strings matching.