-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Feature: adding a Dev Container to Minikube #21686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
star3am
wants to merge
2
commits into
kubernetes:master
Choose a base branch
from
star3am:devcontainer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"name": "Kubernetes - Minikube-in-Docker", | ||
"image": "mcr.microsoft.com/devcontainers/base:bullseye", | ||
"features": { | ||
"ghcr.io/devcontainers/features/docker-in-docker:2": { | ||
"enableNonRootDocker": "true", | ||
"moby": "true" | ||
}, | ||
"ghcr.io/devcontainers/features/kubectl-helm-minikube:1": { | ||
"version": "latest", | ||
"helm": "latest", | ||
"minikube": "latest" | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @star3am for this PR I am curious where is this image coming from and who builds it ? need a comment to know the origins of it
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good day @medyagh that image is from the Devcontainer organisation on Github
Specifically the image comes from mcr.microsoft.com/devcontainers/base:debian (latest)
https://github.com/devcontainers/images/tree/main/src/base-debian
The below page contains information on how Minikube is installed using the feature.
https://github.com/devcontainers/features/pkgs/container/features%2Fkubectl-helm-minikube
More information can be found here https://github.com/devcontainers/features/tree/main/src/kubectl-helm-minikube
The Dev Containers used to be a project by Microsoft, but has been migrated to https://github.com/devcontainers

Can you clarify whether you also wanted a comment in the devcontainer.json file referencing these URLs or just this comment?
Thank you for taking the time to look at my PR and thank you for a great project!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this org owned by microsoft or github ?
and how often the image gets updated? I would prefer an image that minikube project can control and can update
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @medyagh Thank you for your time! As far as I understand, Miscrosoft used to own it and now it's an Org on it's own. See this announcement microsoft/vscode-dev-containers#1762
Seems to be regular releases such as monthly see here: https://github.com/devcontainers/images/releases
If I understand correctly, do you want a Dockerfile with Image source as Docker in Docker such as
FROM docker:dind
and then the minikube install to happen in the Dockerfile? Is that whaat you are looking for?