Skip to content

Fixed TestGetStoragev1 failure in windows #21738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −14
Open

Fixed TestGetStoragev1 failure in windows #21738

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36602fd
Fixed TestGetStoragev1 failure in windows
bobsira Oct 13, 2025
0f64f31
addressed TestGetStoragev1class unit test failure comments
bobsira Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions pkg/minikube/storageclass/storageclass_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"context"
"fmt"
"os"
"path/filepath"
"strings"
"testing"

Expand Down Expand Up @@ -228,19 +229,18 @@ func TestGetStoragev1(t *testing.T) {
err: true,
},
}
configFile, err := os.CreateTemp("/tmp", "")
if err != nil {
t.Fatal(err.Error())
}
defer os.Remove(configFile.Name())

for _, test := range tests {
t.Run(test.description, func(t *testing.T) {
if err := setK8SConfig(t, test.config, configFile.Name()); err != nil {
t.Fatal(err.Error())
tmpDir := t.TempDir()
kubeconfigPath := filepath.Join(tmpDir, "kubeconfig")

if err := setK8SConfig(t, test.config, kubeconfigPath); err != nil {
t.Fatalf("setK8SConfig failed: %v", err)
}

// context name is hardcoded by mockK8sConfig
_, err = GetStoragev1("minikube")
_, err := GetStoragev1("minikube")
if err != nil && !test.err {
t.Fatalf("Unexpected err: %v for test: %v", err, test.description)
}
Expand All @@ -252,12 +252,9 @@ func TestGetStoragev1(t *testing.T) {
}

func setK8SConfig(t *testing.T, config, kubeconfigPath string) error {
mockK8sConfigByte := []byte(config)
mockK8sConfigPath := kubeconfigPath
err := os.WriteFile(mockK8sConfigPath, mockK8sConfigByte, 0644)
if err != nil {
return fmt.Errorf("Unexpected error when writing to file %v. Error: %v", kubeconfigPath, err)
if err := os.WriteFile(kubeconfigPath, []byte(config), 0o644); err != nil {
t.Fatalf("unexpected error when writing to %v: %v", kubeconfigPath, err)
}
t.Setenv("KUBECONFIG", mockK8sConfigPath)
t.Setenv("KUBECONFIG", kubeconfigPath)
return nil
}