Fixed TestMiniPath unit test failure on Windows #21739
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bobsira The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @bobsira. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
|
Can one of the admins verify this patch? |
| if filepath.Base(minikubeHomeEnv) == ".minikube" { | ||
| return minikubeHomeEnv | ||
| // Normalize to platform-specific separators for consistency on Windows. | ||
| return filepath.Clean(filepath.FromSlash(minikubeHomeEnv)) |
There was a problem hiding this comment.
This is value from the MINIKUBE_HOME environment variable. Why do we need to fix value set by the user? they should set the right value, and it the path is invalid the minikube command should fail.
If the issue comes from a test using wrong path, we should fix the test, not the code.
| // Normalize to platform-specific separators for consistency on Windows. | ||
| return filepath.Clean(filepath.FromSlash(minikubeHomeEnv)) | ||
| } | ||
| return filepath.Join(minikubeHomeEnv, ".minikube") |
There was a problem hiding this comment.
However if we need to fix the value for the user, why we don't need to fix it in this case?
4 participants
No description provided.