-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Fixes rpm: Missing vendor value #21759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: divysinghvi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @divysinghvi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you plz add before/after the PR ? you can generate the rpm package using the "make" target for it and compare
actually @medyagh i tried reproducing it on my own system but i was not able to do it like can you give commands for building rpm package on mac arm64 , that's why i was waiting for nirs to verify and i will add the output to the pr description once it is sure this fixes that |
Summary: Machine driver for KVM | ||
License: ASL 2.0 | ||
Group: Development/Tools | ||
Vendor: The Kubernetes Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change conflicts with #21625. Please remove it since this file will be removed soon.
Summary: Run Kubernetes locally | ||
License: ASL 2.0 | ||
Group: Development/Tools | ||
Vendor: The Kubernetes Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting this file breaks the build and is not correct. Remove your changes from this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad will fix it
Are you sure this is the correct output after this change? |
@nirs actually was editing it to put the right output but i was not able to run it on my system can you verify the result please |
OK, if you cannot test it write it clearly in the PR message and do not add fake Before and After. |
understood thanks for the help , will first fix the wrong commit by me |
Fixes rpm: Missing vendor value
//I was not able to verify the fix if any admin can try and verify if this resolves the missing vendor issue
fixes issue #21588
Before