Skip to content

Conversation

divysinghvi
Copy link
Contributor

@divysinghvi divysinghvi commented Oct 17, 2025

Fixes rpm: Missing vendor value
//I was not able to verify the fix if any admin can try and verify if this resolves the missing vendor issue
fixes issue #21588
Before

$ dnf info minikube
Installed packages
Name            : minikube
Epoch           : 0
Version         : 1.37.0
Release         : 0
Architecture    : x86_64
Installed size  : 133.4 MiB
Source          : minikube-1.37.0-0.src.rpm
From repository : @commandline
Summary         : Run Kubernetes locally
URL             : https://github.com/kubernetes/minikube
License         : ASL 2.0
Description     : Minikube is a tool that makes it easy to run Kubernetes locally.
                : Minikube runs a single-node Kubernetes cluster inside a VM on your
                : laptop for users looking to try out Kubernetes or develop with it
                : day-to-day.
Vendor          : <NULL>

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: divysinghvi
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @divysinghvi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you plz add before/after the PR ? you can generate the rpm package using the "make" target for it and compare

@divysinghvi
Copy link
Contributor Author

actually @medyagh i tried reproducing it on my own system but i was not able to do it like can you give commands for building rpm package on mac arm64 , that's why i was waiting for nirs to verify and i will add the output to the pr description once it is sure this fixes that

Summary: Machine driver for KVM
License: ASL 2.0
Group: Development/Tools
Vendor: The Kubernetes Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change conflicts with #21625. Please remove it since this file will be removed soon.

Summary: Run Kubernetes locally
License: ASL 2.0
Group: Development/Tools
Vendor: The Kubernetes Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting this file breaks the build and is not correct. Remove your changes from this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad will fix it

@nirs
Copy link
Contributor

nirs commented Oct 19, 2025

Before

Vendor          : <NULL>

After

Vendor          : <NULL>

Are you sure this is the correct output after this change?

@divysinghvi
Copy link
Contributor Author

@nirs actually was editing it to put the right output but i was not able to run it on my system can you verify the result please

@nirs
Copy link
Contributor

nirs commented Oct 19, 2025

@nirs actually was editing it to put the right output but i was not able to run it on my system can you verify the result please

OK, if you cannot test it write it clearly in the PR message and do not add fake Before and After.

@divysinghvi
Copy link
Contributor Author

understood thanks for the help , will first fix the wrong commit by me

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants