Skip to content

Add initial image commands to smoke test (partial implementation) #21770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+18 −0
Open

Add initial image commands to smoke test (partial implementation) #21770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70cd39c
test: modify smoke test (image load, build)
henry3260 Oct 17, 2025
f02a30f
add image load and image save smoke tests
henry3260 Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/smoke-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,24 @@ jobs:
--driver ${{ matrix.driver }} \
${{ matrix.network_flag }} \
${{ env.LOG_ARGS }}
- name: Copy testdata for image build
run: |
echo ">>> Copying testdata to ./out"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log does not add any value, and it hides the actual command if the step command is folded. Please remove it.

cp -r test/integration/testdata ./out
- name: minikube image load
run: |
./out/minikube image load docker.io/library/alpine ${{ env.LOG_ARGS }}
- name: minikube image save
run: |
echo ">>> Saving alpine image to alpine.tar"
./out/minikube image save docker.io/library/alpine alpine.tar ${{ env.LOG_ARGS }}
- name: minikube image load alpine.tar
run: |
echo ">>> Loading image from alpine.tar into minikube"
./out/minikube image load alpine.tar ${{ env.LOG_ARGS }}
- name: minikube image build
run: |
./out/minikube image build -t test-image ./out/testdata/docker-env ${{ env.LOG_ARGS }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes here belongs to previous commit, please squash.

- name: Inspect minikube
if: always()
run: |
Expand Down