Update minikube-machine with less code lint

[afbjorklund]

• Run golangci-lint on the legacy code minikube-machine/machine#16

module github.com/docker/machine

go 1.17

golangci-lint has version 1.64.8

linters:
  enable:
    - gofmt
    - goimports
    - govet
    - gocyclo

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afbjorklund]

/ok-to-test

[k8s-ci-robot]

@afbjorklund: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-minikube-integration	efb80dd	link	true	/test pull-minikube-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[minikube-pr-bot]

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21772 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 41.3s    │ 41.7s                  │
│ enable ingress │ 19.5s    │ 16.1s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 41.2s 42.6s 39.8s 41.4s 41.7s
Times for minikube (PR 21772) start: 39.3s 42.8s 40.7s 43.8s 41.8s

Times for minikube ingress: 16.3s 15.8s 33.8s 15.8s 15.8s
Times for minikube (PR 21772) ingress: 16.3s 15.8s 16.8s 15.8s 15.8s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21772 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.5s    │ 23.4s                  │
│ enable ingress │ 14.0s    │ 14.8s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 21.7s 22.0s 22.8s 21.8s 23.9s
Times for minikube (PR 21772) start: 20.9s 24.7s 23.5s 25.0s 22.9s

Times for minikube ingress: 10.6s 11.6s 13.6s 12.6s 21.6s
Times for minikube (PR 21772) ingress: 12.6s 12.6s 17.6s 16.6s 14.6s

docker driver with containerd runtime

┌───────────────────┬──────────┬────────────────────────┐
│      COMMAND      │ MINIKUBE │ MINIKUBE  ( PR 21772 ) │
├───────────────────┼──────────┼────────────────────────┤
│ minikube start    │ 20.7s    │ 20.5s                  │
│ ⚠️  enable ingress │ 26.9s    │ 32.7s ⚠️                │
└───────────────────┴──────────┴────────────────────────┘

Times for minikube (PR 21772) start: 20.7s 20.3s 18.8s 23.2s 19.6s
Times for minikube start: 20.2s 20.2s 20.0s 23.6s 19.4s

Times for minikube ingress: 26.1s 22.1s 38.1s 28.1s 20.1s
Times for minikube (PR 21772) ingress: 43.1s 23.1s 21.1s 54.1s 22.1s

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate

Besides the following environments also have failed tests:

• Docker_Linux_crio_arm64: 36 failed (gopogh)

• Docker_Linux_crio: 37 failed (gopogh)

• KVM_Linux_crio: 3 failed (gopogh)

To see the flake rates of all tests by environment, click here.