feat: allow 1 CPU when --no-kubernetes is used#22739
feat: allow 1 CPU when --no-kubernetes is used#22739obaida7 wants to merge 3 commits intokubernetes:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: obaida7 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @obaida7! |
|
Hi @obaida7. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
This PR modifies the
validateCPUCountfunction incmd/minikube/cmd/start.goto allow starting minikube with only 1 CPU when the--no-kubernetesflag is used. This is useful for users running minikube as a container runtime/node manager without the full Kubernetes stack, which requires at least 2 CPUs.Changes:
validateCPUCountto bypass the 2-CPU minimum check whenisNoK8s(from--no-kubernetes) is true.test/integration/no_kubernetes_test.goto use--cpus=1in thevalidateStartNoK8Stest to verify the fix.Fixes #22152