Skip to content

Authenticate GitHub API call in K8s version discovery#22740

Open
manusa wants to merge 1 commit intokubernetes:masterfrom
marcnuri-forks:fix/github-api-auth-k8s-version
Open

Authenticate GitHub API call in K8s version discovery#22740
manusa wants to merge 1 commit intokubernetes:masterfrom
marcnuri-forks:fix/github-api-auth-k8s-version

Conversation

@manusa
Copy link
Contributor

@manusa manusa commented Mar 7, 2026

Summary

IsInGitHubKubernetesVersions creates an unauthenticated GitHub client, which causes
rate-limit errors (HTTP 403) when running minikube within a GitHub Action where
GITHUB_TOKEN is available.

This change reuses the existing oauth2 pattern from pkg/minikube/download/gh/gh.go
so that the client respects the GITHUB_TOKEN environment variable, falling back to
an unauthenticated client when no token is set.

Changes

  • Extract GitHub client creation into a newGitHubClient package-level variable
    for testability (same pattern used in cmd/minikube/cmd/delete.go,
    cmd/minikube/cmd/start.go, etc.)
  • Use GITHUB_TOKEN with oauth2 when available (same wiring as gh.go)
  • Add unit tests for both the release lookup logic and the auth wiring

Follow-up

A cleaner refactor could export a shared NewClient helper from
pkg/minikube/download/gh to avoid duplicating the oauth2 wiring across packages.
Would this be a welcome change? Happy to send a follow-up PR if so.

IsInGitHubKubernetesVersions creates an unauthenticated GitHub client,
which causes rate-limit errors (HTTP 403) when running minikube within
a GitHub Action where GITHUB_TOKEN is available. Reuse the existing
oauth2 pattern from pkg/minikube/download/gh/gh.go so that the client
respects the GITHUB_TOKEN environment variable.

A follow-up refactor could export a shared NewClient helper from
pkg/minikube/download/gh to avoid duplicating the oauth2 wiring.

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: manusa
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2026
@k8s-ci-robot k8s-ci-robot requested a review from medyagh March 7, 2026 05:57
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @manusa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants