chore(exporters): remove deprecated prometheus opts, use otel translator

Author: daveoy

go.mod

@@ -13,6 +13,7 @@ require (
 	github.com/prometheus/client_golang v1.23.2
 	github.com/prometheus/client_model v0.6.2
 	github.com/prometheus/common v0.67.5
+	github.com/prometheus/otlptranslator v1.0.0
 	github.com/prometheus/procfs v0.19.2
 	github.com/shirou/gopsutil/v4 v4.25.12
 	github.com/spf13/pflag v1.0.10
@@ -62,7 +63,6 @@ require (
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
 	github.com/power-devops/perfstat v0.0.0-20240221224432-82ca36839d55 // indirect
-	github.com/prometheus/otlptranslator v1.0.0 // indirect
 	github.com/tklauser/go-sysconf v0.3.16 // indirect
 	github.com/tklauser/numcpus v0.11.0 // indirect
 	github.com/x448/float16 v0.8.4 // indirect

pkg/exporters/prometheusexporter/prometheus_exporter.go

@@ -22,6 +22,7 @@ import (
 	"strconv"
 
 	"github.com/prometheus/client_golang/prometheus/promhttp"
+	"github.com/prometheus/otlptranslator"
 	"go.opentelemetry.io/otel/exporters/prometheus"
 	"k8s.io/klog/v2"
 
@@ -40,9 +41,8 @@ func NewExporterOrDie(npdo *options.NodeProblemDetectorOptions) types.Exporter {
 
 	// Create Prometheus exporter with options to prevent automatic suffixing
 	promExporter, err := prometheus.New(
-		prometheus.WithoutCounterSuffixes(), // Don't add _total suffix to counters
-		prometheus.WithoutUnits(),           // Don't add unit-based suffixes like _ratio
-		prometheus.WithoutScopeInfo(),       // Don't add otel_scope_* labels
+		prometheus.WithTranslationStrategy(otlptranslator.NoTranslation), // Don't add suffixes or escape
+		prometheus.WithoutScopeInfo(),                                    // Don't add otel_scope_* labels
 	)
 	if err != nil {
 		klog.Fatalf("Failed to create Prometheus exporter: %v", err)

pkg/util/otel/common_test.go

@@ -21,6 +21,7 @@ import (
 	"sync"
 	"testing"
 
+	"github.com/prometheus/otlptranslator"
 	"go.opentelemetry.io/otel/exporters/prometheus"
 	sdkmetric "go.opentelemetry.io/otel/sdk/metric"
 	"go.opentelemetry.io/otel/sdk/metric/metricdata"
@@ -182,9 +183,8 @@ func TestPrometheusExporterWithoutScopeLabels(t *testing.T) {
 
 	// Create a Prometheus exporter with WithoutScopeInfo to remove all scope labels
 	promExporter, err := prometheus.New(
-		prometheus.WithoutScopeInfo(),       // Remove all otel_scope_* labels
-		prometheus.WithoutCounterSuffixes(), // Don't add _total suffix to counters
-		prometheus.WithoutUnits(),           // Don't add unit-based suffixes
+		prometheus.WithoutScopeInfo(),                                    // Remove all otel_scope_* labels
+		prometheus.WithTranslationStrategy(otlptranslator.NoTranslation), // Don't add suffixes or escape
 	)
 	if err != nil {
 		t.Fatalf("Failed to create Prometheus exporter: %v", err)