Skip to content

Fix for the coredns configmap update: the corefile was not updated, e… #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix for the coredns configmap update: the corefile was not updated, e… #3378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa88a63
Fix for the coredns configmap update: the corefile was not updated, e…
Tanzp01 Jun 6, 2025
d2bd702
deprecate python2 support
Tanzp01 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dns/py/params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ def is_relevant(self, attributes):
def set(self, inputs, value):
if value > 0:
cf = inputs.configmap_yaml['data']['Corefile']
cfList = cf.decode().split("\n")
# fix the cf type so that it works also for python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just update the code for Python 3? Isn't Python 2 deprecated?

Copy link
Contributor Author

@Tanzp01 Tanzp01 Aug 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bowei for the feedbacks! I have removed the line for python2, now only python3 supported for cleaner code

if(type(cf) == str):
cfList = cf.split("\n")
else:
cfList = cf.decode().split("\n")
cfList.insert(1,
" cache {\n"
" success " + repr(value) + "\n"
Expand Down
2 changes: 1 addition & 1 deletion dns/py/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def go(self):
self._create(inputs.deployment_yaml)
self._create(self.service_yaml)
if self.configmap_yaml is not None:
self._create(self.configmap_yaml)
self._create(inputs.configmap_yaml)
self._wait_for_status(True)
test_threads=[]
#Spawn off a thread to run the test case in each client pod simultaneously.
Expand Down