set GOTOOLCHAIN=auto so automatic verison selection can be used #4215
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
area/release-eng
k8s-ci-robot
added
sig/release
This was referenced Dec 11, 2025
k8s-ci-robot
added
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, cpanato, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Member
Author
|
looks like an external flake (503 service unavailable from github.com) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Ensures when the local desired go version is not aligned we will use that version instead of the version the image contains by default.
GOTOOLCHAIN=autois actually go's default (not the golang image, but the go binary installed locally from upstream)the upstream golang images set GOTOOLCHAIN=local non-default value so you get the version of the image you selected, but this means if e.g. go.mod desired a different version you won't get it (or the .go-version logic in kubernetes/kubernetes)
I don't think we want to drive the exact go version from the images versus in the code under test anywhere in the project, and auto still means the version in the image is the default unless a more specific version is required due to the version selection logic (e.g. you set go.mod to require a higher go version)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/hold