Add clarification for KEPs with only bug fixes going into release are fine to mark as tracked for code freeze for the purposes of enhancements tracking. #2886
Conversation
k8s-ci-robot
added
kind/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SubhasmitaSw The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
… fine to mark as tracked for code freeze for the purposes of enhancements tracking
SubhasmitaSw
force-pushed
the
kep-bug-fixes-clarification
branch
from
da5c356 to
413764f
Compare
k8s-ci-robot
added
size/XS
|
CC: @jenshu |
| **All** enhancements going into the release must have their pull requests in a merge-ready state with approved and lgtm labels applied. This includes tests, and docs PRs opened by the due date. Due to the Prow queue, this may mean that approved PRs merge shortly after the deadline. | ||
| > **Note**: KEPs that contain bug fixes as part of their implementation work (even if the primary work is fixing existing issues rather than adding new features) are perfectly acceptable to mark as `Tracked for code freeze` for the purposes of enhancements tracking. The key requirement is that all code changes are properly reviewed and approved, regardless of whether they introduce new functionality or fix existing issues. |
There was a problem hiding this comment.
Just to clarify, do you mean that KEPs that only contain bug fixes should still be tracked? I think this goes against the messaging from https://groups.google.com/g/kubernetes-sig-release/c/LTzDa7OyBSA/m/IrKW973HAQAJ which says that bug fixes don't need to be tracked
There was a problem hiding this comment.
Yeah, I think changes that do not affect current behavior don’t require a KEP and we don't have to track it.
What type of PR is this:
/kind documentation
What this PR does / why we need it:
Before Code Freeze&Code Freeze TemplatessectionAddresses part of the umbrella issue #2375 to improve the Enhancements Role Handbook
Which issue(s) this PR fixes:
Special notes for your reviewer: