Skip to content

Add clarification for KEPs with only bug fixes going into release are fine to mark as tracked for code freeze for the purposes of enhancements tracking. #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

Add clarification for KEPs with only bug fixes going into release are fine to mark as tracked for code freeze for the purposes of enhancements tracking. #2886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions release-team/role-handbooks/enhancements/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,8 @@ See the sig-architecture Enhancements [KEP Template](https://github.com/kubernet

**All** enhancements going into the release must have their pull requests in a merge-ready state with approved and lgtm labels applied. This includes tests, and docs PRs opened by the due date. Due to the Prow queue, this may mean that approved PRs merge shortly after the deadline.

> **Note**: KEPs that contain bug fixes as part of their implementation work (even if the primary work is fixing existing issues rather than adding new features) are perfectly acceptable to mark as `Tracked for code freeze` for the purposes of enhancements tracking. The key requirement is that all code changes are properly reviewed and approved, regardless of whether they introduce new functionality or fix existing issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, do you mean that KEPs that only contain bug fixes should still be tracked? I think this goes against the messaging from https://groups.google.com/g/kubernetes-sig-release/c/LTzDa7OyBSA/m/IrKW973HAQAJ which says that bug fixes don't need to be tracked

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think changes that do not affect current behavior don’t require a KEP and we don't have to track it.


To avoid delays and ensure everything is in place for Code Freeze:
- **Coordinate with the Release Branch Manager**: Reach out to the Release Branch Manager to give them a heads-up about the upcoming Code Freeze. They are responsible for raising the PR that officially enforces the Code Freeze. Coordinating early helps minimize the risk of delays and last-minute blockers. For more details on their role and responsibilities, refer to the [Release Branch Manager Handbook](https://github.com/kubernetes/sig-release/blob/master/release-engineering/role-handbooks/branch-manager.md)

Expand Down Expand Up @@ -508,6 +510,8 @@ Then make sure the status of the enhancement is set to `Tracked for enhancements

#### Code Freeze Templates

> **Note**: KEPs containing bug fixes as part of their implementation work are acceptable for code freeze tracking as long as all code changes are properly reviewed and approved.

If the Enhancement Issue **does not** meet the code freeze criteria for inclusion in the current release use this template in Issue comments:

```markdown
Expand Down