Skip to content

Conversation

@jkh52
Copy link
Contributor

@jkh52 jkh52 commented Oct 4, 2024

Move lint presubmit to Github Actions.

This PR is Draft because we should not submit until we have the github action in place: kubernetes-sigs/apiserver-network-proxy#658

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 4, 2024
@jkh52
Copy link
Contributor Author

jkh52 commented Oct 4, 2024

/assign @cheftako

@jkh52 jkh52 force-pushed the lint-github-action branch from 3214f32 to 61b2150 Compare October 4, 2024 17:25
@jkh52 jkh52 mentioned this pull request Oct 5, 2024
@jkh52 jkh52 force-pushed the lint-github-action branch from 61b2150 to 8bc5172 Compare October 6, 2024 01:57
@cheftako
Copy link
Member

cheftako commented Oct 8, 2024

@jkh52 Lets move forward with this for now.

@jkh52 jkh52 marked this pull request as ready for review October 8, 2024 17:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2024
@jkh52 jkh52 force-pushed the lint-github-action branch from 8bc5172 to 18faa5c Compare October 12, 2024 20:06
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 12, 2024
@cheftako
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8539813 into kubernetes:master Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

@jkh52: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key apiserver-network-proxy-presubmits-master.yaml using file config/jobs/kubernetes-sigs/apiserver-network-proxy/apiserver-network-proxy-presubmits-master.yaml

In response to this:

Move lint presubmit to Github Actions.

This PR is Draft because we should not submit until we have the github action in place: kubernetes-sigs/apiserver-network-proxy#658

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants