Skip to content

fix branch selection pattern#34363

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Prajyot-Parab:master
Feb 19, 2025
Merged

fix branch selection pattern#34363
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Prajyot-Parab:master

Conversation

@Prajyot-Parab
Copy link
Member

@Prajyot-Parab Prajyot-Parab commented Feb 19, 2025

fix branch selection pattern

What is happening?

  • After the release of v0.10.0 in CAPIBM, we added job configurations for it in test-infra. However, we noticed that the release-0.1 jobs are also being triggered for the release-0.10 branch. This issue occurs because the branch selection pattern for release-0.1 is set to ^release-0.1, which also matches the release-0.10 string and triggers the checks.

What should happen?

  • After fixing the pattern to ^release-0.1$, we expect the jobs to be triggered only for the release-0.1 branch and not for release-0.10. This change will prevent incorrect checks from being triggered on incoming PRs in case of conflicts in patterns. Additionally, the pattern change will be propagated across all the different release branches to avoid future issues and conflicts.

ref - release-0.1 job got triggered against PR on release-0.10 branch
kubernetes-sigs/cluster-api-provider-ibmcloud#2203

Signed-off-by: Prajyot Parab <Prajyot.Parab2@ibm.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2025
@Prajyot-Parab
Copy link
Member Author

/cc @Amulyam24

@mkumatag
Copy link
Member

@Prajyot-Parab can you please elaborate the issue and how this fix solves the issue in the description? is possible GitHub issue pointing to.

@Prajyot-Parab
Copy link
Member Author

@Prajyot-Parab can you please elaborate the issue and how this fix solves the issue in the description? is possible GitHub issue pointing to.

@mkumatag updated the description.

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit dfef626 into kubernetes:master Feb 19, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Prajyot-Parab: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-ibmcom-presubmits-release-0.1.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presubmits-release-0.1.yaml
  • key cluster-api-provider-ibmcom-presubmits-release-0.2.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presubmits-release-0.2.yaml
  • key cluster-api-provider-ibmcom-presubmits-release-0.3.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presubmits-release-0.3.yaml
  • key cluster-api-provider-ibmcom-presubmits-release-0.4.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presubmits-release-0.4.yaml
  • key cluster-api-provider-ibmcom-presubmits-release-0.5.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presubmits-release-0.5.yaml
  • key cluster-api-provider-ibmcom-presubmits-release-0.6.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presubmits-release-0.6.yaml
  • key cluster-api-provider-ibmcom-presubmits-release-0.7.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presubmits-release-0.7.yaml
  • key cluster-api-provider-ibmcom-presubmits-release-0.8.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presubmits-release-0.8.yaml
  • key cluster-api-provider-ibmcom-presubmits-release-0.9.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presubmits-release-0.9.yaml
  • key cluster-api-provider-ibmcom-presumbits-release-0.10.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presumbits-release-0.10.yaml
Details

In response to this:

fix branch selection pattern

What is happening?

  • After the release of v0.10.0 in CAPIBM, we added job configurations for it in test-infra. However, we noticed that the release-0.1 jobs are also being triggered for the release-0.10 branch. This issue occurs because the branch selection pattern for release-0.1 is set to ^release-0.1, which also matches the release-0.10 string and triggers the checks.

What should happen?

  • After fixing the pattern to ^release-0.1$, we expect the jobs to be triggered only for the release-0.1 branch and not for release-0.10. This change will prevent incorrect checks from being triggered on incoming PRs in case of conflicts in patterns. Additionally, the pattern change will be propagated across all the different release branches to avoid future issues and conflicts.

ref - release-0.1 job got triggered against PR on release-0.10 branch
kubernetes-sigs/cluster-api-provider-ibmcloud#2203

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants