-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update DRA scalability job with CL2 with more logs #35105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5389cfd
to
3dffa3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
base_ref: master | ||
path_alias: k8s.io/kubernetes | ||
- org: kubernetes | ||
- org: nojnhuh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we want to get runs with these changes ASAP before a PR upstream could probably be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we are looking into some apiserver availability flakes and want more logs, see:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened kubernetes/perf-tests#3437 in the meantime so we can change this back to upstream as soon as that merges.
/lgtm |
@nojnhuh: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR updates the CL2 used for the Azure DRA scale test with these changes: kubernetes/perf-tests@master...nojnhuh:perf-tests:api-avail-err-log
/assign @jackfrancis