-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add pull-kops-aws-distro-al2023-canary for testing CI changes #35263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/hold for @ameukam to take a look |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Youll probably need to add this job to a new file that doesn't get overwritten by build_jobs.py. Perhaps a |
Signed-off-by: Marko Mudrinić <[email protected]>
New changes are detected. LGTM label has been removed. |
@xmudrii: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I think there are still some minor issues to pass the tests. |
Follow up on kubernetes/kops#17520 based on discussion with @ameukam
This job should run in the
kops-ci
account as it doesn't have the AWS present. We can't test kubernetes/kops#17520 with the current account which is in the CNCF org because there's an org level policy forbidding creating public access buckets in the org./assign @ameukam @hakman @rifelpet