Skip to content

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 5, 2025

Follow up on kubernetes/kops#17520 based on discussion with @ameukam

This job should run in the kops-ci account as it doesn't have the AWS present. We can't test kubernetes/kops#17520 with the current account which is in the CNCF org because there's an org level policy forbidding creating public access buckets in the org.

/assign @ameukam @hakman @rifelpet

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2025
@xmudrii
Copy link
Member Author

xmudrii commented Aug 5, 2025

/hold for @ameukam to take a look

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 5, 2025
@hakman
Copy link
Member

hakman commented Aug 5, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2025
@rifelpet
Copy link
Member

rifelpet commented Aug 5, 2025

Youll probably need to add this job to a new file that doesn't get overwritten by build_jobs.py. Perhaps a kops-presubmits-misc.yaml

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@xmudrii
Copy link
Member Author

xmudrii commented Aug 5, 2025

@ameukam @rifelpet Comments addressed, PTAL

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 5, 2025

@xmudrii: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-unit-test 004657b link true /test pull-test-infra-unit-test
pull-test-infra-unit-test-race-detector-nonblocking 004657b link false /test pull-test-infra-unit-test-race-detector-nonblocking

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Aug 5, 2025

I think there are still some minor issues to pass the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants