-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add image push job for karpenter-cluster-api-provider #35802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add image push job for karpenter-cluster-api-provider #35802
Conversation
|
/hold |
f68b5a3 to
d7a43e4
Compare
|
Waiting on kubernetes-sigs/karpenter-provider-cluster-api#56 to merge. |
|
/unhold |
|
/cc @BenTheElder @dims |
| # # do not run on dependabot branches, these exist prior to merge | ||
| # # only merged code should trigger these jobs | ||
| # - '^dependabot' | ||
| branches: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably also want to include version tags, while the field says "branches", it's misnamed (... too late to easily fix), it really matches github push events, which includes also tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, added a line for semver tags :-) thanks.
Signed-off-by: Max Cao <[email protected]>
d7a43e4 to
df67d8d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maxcao13 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Followup from: kubernetes/k8s.io#8557 and kubernetes-sigs/karpenter-provider-cluster-api#54 as part of kubernetes-sigs/karpenter-provider-cluster-api#18.