Skip to content

[Feature Cleanup] Remove APIServerIdentity from test, bump api group to beta #35941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

[Feature Cleanup] Remove APIServerIdentity from test, bump api group to beta #35941

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c18b97
removed APIServerIdentity env arg and bumped api group to beta - for …
mariafromano-25 Nov 20, 2025
f6cad50
leaving api as alpha
mariafromano-25 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../jobs/kubernetes-sigs/kube-storage-version-migrator/kube-storage-version-migrator-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ presubmits:
- --test-cmd=../test/e2e/test-fully-automated.sh
- --test-cmd-args=--focus=\[Disruptive\]
- --timeout=50m
- --runtime-config=internal.apiserver.k8s.io/v1alpha1=true
- --env=KUBE_FEATURE_GATES=StorageVersionAPI=true,APIServerIdentity=true
- --runtime-config=internal.apiserver.k8s.io/v1beta1=true
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it enabled by default or should be explicitly enabled?

Copy link
Member

@roycaihw roycaihw Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized the internal.apiserver.k8s.io API is for StorageVersionAPI, not for APIServerIdentity. StorageVersionAPI and internal.apiserver.k8s.io are still in alpha and need to be explicitly enabled.

https://github.com/kubernetes/kubernetes/blob/master/api/discovery/apis__internal.apiserver.k8s.io.json

Copy link
Member

@roycaihw roycaihw Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariafromano-25 The files being modified are for StorageVersionAPI, which is a different feature than APIServerIdentity.

You can clean up APIServerIdentity=true since this feature gate is now beta and enabled by default, but you need to keep internal.apiserver.k8s.io/v1alpha1=true and StorageVersionAPI=true since these are the alpha API & feature gate for the StorageVersionAPI test to work.

- --env=KUBE_FEATURE_GATES=StorageVersionAPI=true
# docker-in-docker needs privileged mode
securityContext:
privileged: true
Expand Down
3 changes: 1 addition & 2 deletions ...bernetes-sigs/kube-storage-version-migrator/kube-storage-version-migrator-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ presubmits:
- --test-cmd=../test/e2e/test-fully-automated.sh
- --test-cmd-args=--skip=\[Disruptive\]
- --timeout=50m
- --runtime-config=internal.apiserver.k8s.io/v1alpha1=true
- --env=KUBE_FEATURE_GATES=StorageVersionAPI=true,APIServerIdentity=true
- --env=KUBE_FEATURE_GATES=StorageVersionAPI=true
# docker-in-docker needs privileged mode
securityContext:
privileged: true
Expand Down